microsoft / microsoft/TypeScript
Incorrect completions in object literal expression for overloads
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 117
Description
Bug Report
🔎 Search Terms
🕗 Version & Regression Information
⏯ Playground Link
Code to test
Simplified from got typings.
interface T {
<T>(input: { type: 'text' })
<T>(input: { type: 'json' })
<T>(input: { type: 'buffer' })
}
declare const func: T
func({ type: /**/ })
No all literal or in-string completions, but okay if remove <T> from each overload.
🙁 Actual behavior
Completions in func({ type: '|' }) (text) missing completions from func2('|') (text, json, buffer)
🙂 Expected behavior
Completions for func({ type: '|' }) are the same as for func2('|')
I'm not sure probably its related to https://github.com/microsoft/TypeScript/issues/51047 (or duplicate)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue in the linked TypeScript Playground using the provided overload example, then compare completions inside the object literal with completions for the direct literal argument. Done means the object-literal expression offers the same text, json, and buffer completions as the direct call.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100