microsoft / microsoft/TypeScript
Deep readonly type with a nested tuple made deep writeable incorrectly extends `never`
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- Go
- Estrellas
- 111k
- Forks
- 14.4k
- Merge medio
- 1 d 19 h
- PR fusionados (30 d)
- 117
Descripción
Bug Report
🔎 Search Terms
never tuple
readonly tuple
change name of type
change result of type
🕗 Version & Regression Information
- This changed between versions 4.4.4 (correct) and 4.5.5 (incorrect) and 4.6.4 (correct) and >= 4.7.4, <= 5.2.2 (incorrect) and 5.3.2 (correct)
⏯ Playground Link
Playground link with relevant code
💻 Code
type DeepWriteable<T> = { -readonly [P in keyof T]: DeepWriteable<T[P]> };
type IsNever<T> = [T] extends [never] ? true : false;
type DeepExactArray<Arr extends any[], Shape> = {
[K in keyof Arr]: DeepExactShape<Arr[K], Shape[K & keyof Shape]>;
};
type DeepExactShape<Obj, Shape> =
(
Obj extends Shape
? (
Shape extends any
? (
Obj extends any[]
? DeepExactArray<Obj, Shape>
: (
IsNever<Exclude<keyof Obj, keyof Shape>> extends true
? (
Obj extends object
? {
[K in keyof Obj]: K extends keyof Shape ? DeepExactShape<Obj[K], Shape[K]> : never;
}
: Obj
)
: never
)
)
: never
)
: never
);
const obj = {
topLevel: {
data: {
myTuple: [{ tup1: null, extra: '' }]
}
}
} as const;
type Obj = DeepWriteable<typeof obj>;
type ShapeToValidate = {
topLevel: {
data?: {
myTuple: [{ tup1: null }] | null;
};
}
};
type ValidatedShape = DeepExactShape<Obj, ShapeToValidate>;
// ^? { topLevel: { data: { myTuple: [never]; }; }; }
type test = Obj extends ValidatedShape ? true : false;
// ^? type test = true;
type test2 = Obj extends { topLevel: { data: { myTuple: [never]; }; }; } ? true : false;
// ^? type test2 = false;
const thing: test = false; // Changing the name of type test, for example, to tes, in either usage negates the type from false to true, then back to false
🙁 Actual behavior
A type with a multi-level nested tuple incorrectly extends itself but with a slight modification: the element of the tuple is replaced with never, but only when the type is created the using above DeepExactShape type. When using the same type with the never replacement, but explicitly written out instead, it correctly does not extend.
In addition, when removing the as const statement, it correctly does not extend. When changing the nested depth of the tuple from 3 to 2 (removing the topLevel property), it correctly does not extend.
Finally, when changing the name of type test, for example, to tes, in either usage negates the type from false to true, then back to false as visible in the two-slash query and when hovering over the type (in 4.7.4 and above)
🙂 Expected behavior
In both cases, the initial type, Obj, should not extend either the created type (from DeepExactShape), or the explicitly defined type, with, or without, the as const statement included.
Changing the name of a type should not result in the value of the type being different.
The degree of nesting (2 vs 3) should not change whether the type extends the created type.
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Comienza con el TypeScript Playground enlazado y reproduce el ejemplo de tupla anidada en las versiones indicadas en el informe. Compara los tipos calculados para ValidatedShape, test y test2 mientras cambias el nombre del tipo, la profundidad de anidamiento y as const; se considera completado cuando estas variaciones producen de forma consistente el resultado esperado sin extensión.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- typescript
- Área
- compilers
- Tipo de issue
- Error
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 35/100