microsoft / microsoft/TypeScript

Use context to prioritize or only show `case` and `default` in a `switch` statement

Aperta
#52,234 0 commenti 1 reazione 1 assegnatario Vedi su GitHub

Nessuno ha ancora preso questa issue.

Domain: LS: Completion Lists In Discussion Suggestion
Lingua principale
Go
Stelle
111k
Fork
14.4k
Merge medio
1g 19h
PR unite (30g)
117

Descrizione

While playing around with switch/case snippets, I ran into the following:

switch (someValue) {
    /**/
}

Request completions at /**/

The only completions that should be offered here are case and default (along with corresponding snippet completions). It's bad that we don't do that because these keywords are always sorted to come after any other invalid completions.

Fixing just this is one small case. If we wanted to go deeper, I would propose that we use the line and column of the current case or default clause to inform what completions we offer.

Some test cases I would want to remain the same or change:

// same - show all completions
switch (thing) {
  case 42:
  /*$*/
}
// same - show all completions
switch (thing) {
  case 42:
  break;
  /*$*/
}
// same - show all completions
switch (thing) {
  case 42:
  if (Math.random()) {
  }
  else {
  }
  /*$*/
}
// NEW - prioritize `case`/`default`
switch (thing) {
  case 42:
    break;
  /*$*/
}
// NEW - prioritize `case`/`default`
switch (thing) {
  case 42: break;
  /*$*/
}
// NEW - prioritize `case`/`default`
switch (thing) {
  case 42: {
  }
  break;
  /*$*/
}

The current closest approximation I can think of is:

  • the cursor is at the same column as the containing clause's case/default keyword, but on a different line, and
  • there is at least one statement in the clause, and any of the following are true:
    • the last statement is one that would jump out of the current control flow (e.g. break/return/throw/continue)
    • the start of the last statement's token is on a different line and column as the containing clause's case/default keyword

then we should actually ensure case and default appear at the top.

This case:

// NEW - prioritize `case`/`default`/`break`
switch (thing) {
  case 42: {
    // ...
  }
  /*$*/
}

is one that might get another special-case where we'd possibly want to provide break if we don't see it as the last statement of the block. But I'm curious to hear others' thoughts.

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.