microsoft / microsoft/TypeScript

Narrowing types with private functions with `this` return type fails

Aperta
#44,785 3 commenti 1 reazione 1 assegnatario Vedi su GitHub

@weswigham ci sta già lavorando.

Dal 1/7/2021.

Needs Investigation Rescheduled
Lingua principale
Go
Stelle
111k
Fork
14.4k
Merge medio
1g 19h
PR unite (30g)
117

Descrizione

Bug Report

I found that a generic type may be evaluated as incompatible while in fact it should be compatible. In my particular case I have a few generic types / classes that have a type argument constrained to MyClass.
I also have a conditional type with a generic argument that is "less" constrained to a union type of MyClass and a different class that has a generic.

// Conditional type with a generic constrained to either MyClass or something else
type ConditionalType<T extends MyClass | string> =
  T extends MyClass ? MyGenericType<T> : T;

In the given constellation I get the following error:

Type 'MyClass & T' does not satisfy the constraint 'MyClass'.
  Property 'fn' is missing in type 'MyClass & T' but required in type 'MyClass'.(2344)

I found that these prerequisites have to be met to reproduce the error:

  1. The class (MyClass) that we constrain the generics arguments to has a function that returns a this type.
    Edit: Or no type annotation, no matter what the inferred type is. Other return type annotations, e.g. : string work.
  2. This function is either protected or private.
🔎 Search Terms

this type, generic, conditional types

🕗 Version & Regression Information
  • This is the behavior in every version I tried, and I reviewed the FAQ for entries about: seems to me that none apply.
⏯ Playground Link

Playground link with relevant code

💻 Code
// The class to constrain to in the generic types
class MyClass {
  constructor(public name: string) {}

  protected fn(): this {
    return this;
  }
}

// A generic type with a type argument constrained to MyClass
type MyGenericType<T extends MyClass> = T;

// Conditional type with a generic constrained to either MyClass or something else
type ConditionalType<T extends MyClass | string> =
  T extends MyClass ? MyGenericType<T> : T;
🙁 Actual behavior

Although the condition in the mapped type constrains the given type to extend MyClass it is not compatible as the type here evaluates to MyClass & T.

🙂 Expected behavior

I would expect that the condition in the type narrows the type as given in the condition.

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.