microsoft / microsoft/TypeScript
Cannot bracket-index into an object after checking it's existence on that object.
@DanielRosenwasser is already working on this.
Since May 20, 2021.
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
Bug Report
Cannot bracket-index into an object after checking it's existence on that object.
The same failure was reported in #43651, but I couldn't find a separate discussion or a ticket for this.
🔎 Search Terms
- implicitly has an 'any' type
- bracket indexing
🕗 Version & Regression Information
Worked in 4.2.4. Starts to break since 4.3.0-beta
⏯ Playground Link
💻 Code
interface A {}
function foo(a:A) {
if ('abc' in a) {
const z = a;
// Element implicitly has an 'any' type because expression of type '"abc"' can't be used to index type 'A'.
// Property 'abc' does not exist on type 'A'.
return z['abc'];
}
}
🙁 Actual behavior
Compiler gives an error that you cannot index into type 'A', since 'abc' does not exist in type 'A'
🙂 Expected behavior
Compiler recognizes the existence check and does not give an error.
Observation
This seems to be caused by the improvement in the control flow analysis/type inference. Before the type of z in the below example was 'never' prior to TS4.3, but now the compiler recognizes z being type A
Question : I have one question though, is it by design that it's allowed to index into never types?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.