microsoft / microsoft/TypeScript

Type inference not working as expected when using key remapping in mapped types

Abierto
#44,115 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Needs Investigation
Lenguaje dominante
Go
Estrellas
111k
Forks
14.3k
Merge medio
1 d 19 h
PR fusionados (30 d)
117

Descripción

Bug Report

🔎 Search Terms

mapped types, key remapping using as, type inference

🕗 Version & Regression Information

I tested this with all versions available on typescriptlang.org/play including nightly. I was unable to test this on versions < 4.1 because key-remapping does not exist prior to version 4.1.

⏯ Playground Link

Playground link with relevant code

💻 Code
// simple Maybe implementation for testing:
type Some<T> = {__kind: "Some", boxed: T}
type None = {__kind: "None"}
type Maybe<T> = Some<T> | None
function Some<T>(value: T): Maybe<T> {return {__kind: "Some", boxed: value}}
function None(): Maybe<unknown> {return {__kind: "None"}}


type MatchCases<T extends {__kind: K}, K extends string, R> = {[V in T as V["__kind"]]: (variant: V) => R}

function match<T extends {__kind: K}, K extends string, R>(variant: T, cases: MatchCases<T, K, R>): R {
    const _case = cases[variant.__kind]
    // _case is expected to receive an argument of type K instead of V
    return _case(variant)
}

// Example 1
// Declaring types explicitly works fine, the argument type of Some handler is inferred correctly.
// I intentionally use 'string' and 'unknown' instead of "None | Some" and 'number'
// to reflect the inferred types from below:
const withExplicitTypes = match<Maybe<number>, string, unknown>(Some(5), {
    None: () => 1,
    Some: ({boxed}) => boxed * 2
})

// Example 2
// The compiler infers the exact same types as above:
const withTypeInference = match(Some(5), {
    None: () => 1,
    // But the argument to Some-handler cannot be inferred correctly:
    Some: some => some.boxed 
})
🙁 Actual behavior

I might be misusing the key remapping feature, but while implementing the above mentioned match function, I ran into following behavior:

  • calling match above with explicit generic types works as expected (Example 1)
  • the compiler infers the exact same types when not provided explicitly, but the arguments to the case handlers are inferred as any (Example 2), even that intellisense initially proposes the correct type while typing (see [1])
  • when trying to call a case function in the body of match, the expected type of the argument is K instead of T.
🙂 Expected behavior
  • I'm expecting _case to require an argument of type V as declared in the mapped type ((variant: V) => R).
  • Based on the inferred types of MatchCases, the argument of the Some-handler should be inferred to type Some<number>.

[1]:

image

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Comienza con el TypeScript Playground enlazado y los ejemplos proporcionados de MatchCases y match para reproducir el fallo de inferencia. Rastrea el remapeo de claves en tipos mapeados y la inferencia genérica; se considera terminado cuando el manejador Some recibe Some y la llamada a _case acepta el tipo de variante mapeado en lugar de K.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
typescript
Área
compilers
Tipo de issue
Error
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
45/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.