microsoft / microsoft/TypeScript

Function identifiers no longer receive semantic highlighting tokens

Aperta
#44,099 2 commenti 0 reazioni 1 assegnatario Vedi su GitHub

@orta ci sta già lavorando.

Dal 14/5/2021.

Needs Investigation Rescheduled
Lingua principale
Go
Stelle
111k
Fork
14.3k
Merge medio
2g 4h
PR unite (30g)
132

Descrizione

Bug Report

Function identifiers (including methods) don't appear to be receiving semantic highlighting tokens from the LSP as of TS 4.2.x.

This is important to me because I prefer the terser style of passing callbacks directly by identifier instead of always wrapping them in anonymous lambdas (e.g., myArray.filter(myPredicate) instead of myArray.filter(it => myPredicate(it))), but with the semantic colorization missing, it's much harder to recognize where this is happening when scanning code.

🔎 Search Terms

semantic highlight, highlighting, function, token

🕗 Version & Regression Information
  • Semantic function tokens worked as expected in 4.1.5
  • They appear to be missing in 4.2.4 (VS Code's version at time of writing)
💻 Code

CodeSnap with TS v4.0.7:
ts40-func-tokens

CodeSnap with TS v.4.2.4:
ts42-func-tokens

Textual representation for the sake of screen-readers and whatnot:

let result = [...newFiles];

const compareFileName: Comparator<INewFile|IDisplayFile> = (a, b) => a.FileName === b.FileName;
const isDisplayFile = (item: INewFile|IDisplayFile): item is IDisplayFile => !!item.ExternalId;

const currentFiles = this._displayFiles$.value ?? [];
const dupes = intersectionWith(compareFileName, newFiles, currentFiles);

if (!dupes.length) {
	return result;
}

// Find the sets of current files and new uploads that are unique.
const [currentUniques, newUniques] = flow(
	xorWith(compareFileName),
	partition(isDisplayFile),
)(currentFiles, newFiles);
🙁 Actual behavior

In the newer snap, notice that references to compareFileName and isDisplayFile are colored as ordinary variables after their declarations. Invoking VS Code's "Inspect Editor Tokens and Scopes" command on those tokens indicates that they're falling back to their TextMate scopes instead of using the semantic information.

🙂 Expected behavior

In the older snap, all references to the function names are colored as functions, making it easier to spot which arguments are callbacks when scanning the code. Invoking the "Inspect..." command on these shows that they're marked with the function semantic token type, with readonly and local modifiers.

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.