microsoft / microsoft/TypeScript

Enable chokidar-based watch

Aperta
#43,790 6 commenti 4 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Awaiting More Feedback Suggestion
Lingua principale
Go
Stelle
111k
Fork
14.3k
Merge medio
2g 4h
PR unite (30g)
132

Descrizione

Suggestion

🔍 Search Terms

idle watch watcher cpu chokidar

✅ Viability Checklist

My suggestion meets these guidelines:

  • This wouldn't be a breaking change in existing TypeScript/JavaScript code
  • This wouldn't change the runtime behavior of existing JavaScript code
  • This could be implemented without emitting different JS based on the types of the expressions
  • This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
  • This feature would agree with the rest of TypeScript's Design Goals.
    Would actually further goal 10, cross-platform development

⭐ Suggestion

Please add one or more of these:

  • chokidar as a new option for tsconfig::watchOptions.watchFile and tsconfig::watchOptions.watchDirectory
  • chokidar as a new option for env::TSC_WATCHFILE and env::TSC_WATCHDIRECTORY
  • chokidar as default watcher – maybe dependent on whether chokidar is available in the project

💻 Use Cases

While working with create-react-app, I noticed that my machine tended to get quite loud. Investigating that, I found the reason to be surprisingly large CPU utilization. That, in turn, I could trace back to this issue:
https://github.com/TypeStrong/fork-ts-checker-webpack-plugin/issues/236

The solution there was to switch TSC to fs.watch instead of fs.watchFile. That works for the most part. However, as @sheetalkamat points out in https://github.com/microsoft/TypeScript/issues/31048#issuecomment-495659901, that implementation is known to be problematic. Which is why it is not the default and won't be in the foreseeable future.

Prior discussions

https://github.com/microsoft/TypeScript/issues/31048 talks about the background to this request. There, @nicoburns already asked about this:

Would you consider switching to Chokidar? It's a battle tested solution used very widely throughout the Node ecosystem. We're in the process of switching to TypeScript at work, and the watch processes are taking ~45% cpu each on my 2015 MacBook Pro. As far as I am aware Node's built-in file watching capabilities are generally considered broken and not suitable for production use.

In response, @jasonwilliams pointed out that webpack had switched back to fs.watch, which might indicate that it had been fixed by now. Unfortunately, node v16 still has the same warnings, and webpack's switch seems to have been less thoroughly investigated than we would have desired: https://github.com/webpack/watchpack/issues/130

https://github.com/microsoft/TypeScript/issues/19762 and https://github.com/microsoft/TypeScript/issues/17506 also showed performance issues. https://github.com/microsoft/TypeScript/issues/19762 actually has the same resolution as https://github.com/TypeStrong/fork-ts-checker-webpack-plugin/issues/236, and https://github.com/microsoft/TypeScript/issues/17506 seems to have prompted some intensive work.

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Direzione di ricerca

La issue non indica file, test o punti di ingresso specifici. Inizia esaminando le opzioni di watch esistenti di TypeScript e le discussioni precedenti collegate, quindi determina se chokidar debba essere un'opzione o il valore predefinito e come dovrebbe funzionare la configurazione; il completamento richiederebbe un design concordato e un ambito di implementazione definito.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
node.js, typescript
Ambito
devtools
Tipo di issue
Funzionalità
Difficoltà
5/5
Tempo stimato
Più di una settimana
Stato di attività
Ferma
Chiarezza
Abbastanza chiara
Idoneità per principianti
25/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.