microsoft / microsoft/TypeScript
TypeScript unable to infer types properly between interfaces and overloaded methods.
未关闭
还没有人认领这个 Issue。
Needs Proposal
Suggestion
- 主要语言
- Go
- 星标
- 111k
- 派生
- 14.4k
- 平均合并
- 1 天 19 小时
- 30 天内合并 PR
- 117
描述
Bug Report
In all versions of TS I can find, there's no way to mark certain call patterns of a method as deprecated while maintaining inference with certain interfaces. If an interface is split out into different overloads so certain overloads can be deprecated, then it breaks inference in some cases.
🔎 Search Terms
I'm not sure what to search for here. Interfaces?
🕗 Version & Regression Information
- All versions
⏯ Playground Link
Playground link with relevant code
💻 Code
interface Observer<T> {
next(value: T): void;
error(error: any): void;
complete(): void;
}
interface Unsubscribable {
unsubscribe(): void;
}
interface Subscribable<T> {
subscribe(observer?: Partial<Observer<T>>): Unsubscribable;
}
class Observable<T> implements Subscribable<T> {
/////////////////////////////////////////
// Valid call pattern
/////////////////////////////////////////
subscribe(observerOrNext?: Partial<Observer<T>> | ((value: T) => void)): Unsubscribable;
//////////////////////////////////////////
// Deprecated call patterns
//////////////////////////////////////////
/**
* @deprecated This call pattern is going away
*/
subscribe(next: null | undefined, error: null | undefined, complete: () => void): Unsubscribable;
/**
* @deprecated This call pattern is going away
*/
subscribe(next: null | undefined, error: (error: any) => void, complete?: () => void): Unsubscribable;
/**
* @deprecated This call pattern is going away
*/
subscribe(next: (value: T) => void, error: null | undefined, complete: () => void): Unsubscribable;
/**
* @deprecated This call pattern is going away
*/
subscribe(next?: (value: T) => void, error?: (error: any) => void, complete?: () => void): Unsubscribable;
////////////////////////////////////////////
// Impl
////////////////////////////////////////////
subscribe(...args: any[]): Unsubscribable {
return {
unsubscribe() {}
};
}
}
function somethingThatTakesSubscribable<T>(arg: Subscribable<T>): T {
return null!;
}
/////////////////////////////////////
// Our failed expectation here
// (it's unknown)
/////////////////////////////////////
const result = somethingThatTakesSubscribable(new Observable<number>()); // $ExpectType number
🙁 Actual behavior
result is unknown above.
🙂 Expected behavior
result would be number.
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
从链接的 TypeScript Playground 开始,复现传递给 somethingThatTakesSubscribable 的 Observable 的推断结果。调查拆分后的 overload(包括已弃用的签名)如何与 Subscribable 进行比较。完成的标准是同一个示例将 result 推断为 number 而不是 unknown,并且覆盖报告的 overload 模式。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- typescript
- 领域
- compilers
- Issue 类型
- 缺陷
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 活跃度
- 停滞
- 描述清晰度
- 基本清楚
- 新手友好度
- 35/100