microsoft / microsoft/TypeScript

Support for both public and protected constructor overload signatures

Abierto
#43,616 8 comentarios 3 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Awaiting More Feedback Suggestion
Lenguaje dominante
Go
Estrellas
111k
Forks
14.4k
Merge medio
1 d 19 h
PR fusionados (30 d)
117

Descripción

Suggestion

TypeScript already supports abstract class, which cannot be instantiated (of course, I know they can — it's just the compiler that disallow that). Non–abstract classes, on the other hand, can be instantiated using any constructor overload they provide.
There are cases, however, when you may want to allow creation of a class using only one constructor overload and provide another one for subclasses to use. The latter is what I would call “protected constructor,” which could be defined with the addition of the modifier protected. However, it looks like TypeScript currently doesn't support overloads with different access modifiers; I wonder why, as signature matching is merely a static check and doesn't change the way the method is actually invoked. If different overload signatures were allowed to support different access modifiers, the scenario with a protected constructor and a public one I described would be permitted.

🔍 Search Terms

protected constructor
abstract constructor

✅ Viability Checklist

My suggestion meets these guidelines:

  • This wouldn't be a breaking change in existing TypeScript/JavaScript code
  • This wouldn't change the runtime behavior of existing JavaScript code
  • This could be implemented without emitting different JS based on the types of the expressions
  • This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
  • This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion

Just allow having different access modifiers for different overload signatures. There's no need I can see to disallow that and it wouldn't be difficult at all to implement.

📃 Motivating Example

Suppose I want to use the composition pattern and provide default sub–instances in the public constructor but still allow subclasses to pass their own sub–instances, as follows:

class Controller {}

class View {

    constructor();

    protected constructor(controller: Controller);

    constructor(readonly controller: Controller = new Controller()) {}
}

class CustomController extends Controller {}

class CustomView extends View {

    constructor() {
        super(new CustomController());
    }
}

💻 Use Cases

Additionally to the “protected constructor” use case I described above, since such a feature requires, as previously mentioned, allowing different access modifiers across overload signatures, this change would also permit a lot of other things. I suppose you all can understand that having protected signatures for a subclass and exposing only public signatures for other sites may turn useful.

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Comienza revisando cómo TypeScript gestiona las firmas de sobrecarga de constructores y los modificadores de acceso. Valida el ejemplo motivador con una sobrecarga de constructor pública y una sobrecarga protegida para subclases. Se considera terminado cuando el ejemplo supera la comprobación de tipos, mientras que las llamadas que utilizan la firma protegida siguen sin estar disponibles para código no relacionado.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
typescript
Área
compilers
Tipo de issue
Nueva funcionalidad
Dificultad
5/5
Tiempo estimado
Más de una semana
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
35/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.