microsoft / microsoft/TypeScript
`--explainFiles` differentiate `import type ...` vs `import`
Dieses Issue hat noch niemand übernommen.
- Vorherrschende Sprache
- Go
- Sterne
- 111k
- Forks
- 14.3k
- Ø Merge
- 1 T. 19 Std.
- Gemergte PRs (30 T.)
- 117
Beschreibung
Suggestion
explainFiles "import type"
✅ Viability Checklist
My suggestion meets these guidelines:
- This wouldn't be a breaking change in existing TypeScript/JavaScript code
- This wouldn't change the runtime behavior of existing JavaScript code
- This could be implemented without emitting different JS based on the types of the expressions
- This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
- This feature would agree with the rest of TypeScript's Design Goals.
⭐ Suggestion
I would like the --explainFiles behavior to differentiate between import type and import runtime imports in its printout.
📃 Motivating Example
c:/project/src/server-side/contract
Imported Types via '../server-side/contract' from file 'c:/project/src/client-side/app.tsx'
^^^^^
💻 Use Cases
I am looking for suspected non-import type ... imports that are poisoning our build, bleeding code from non-client files ultimately into client bundles (before maybe tree-shaking them out again). At best, this impacts build performance. I know that better code organization could help avoid confusing import chains and improper imports - that's what I'm trying to untangle it for.
I am using the output from --explainFiles to recognize the various patterns and reconstitute a dependency graph:
const targetPattern = /^(?!\s)(.*)/;
const importedViaPattern = /^ Imported via (['"])(.*)\1 from file '([^']*)'/;
const includePattern = /^ Matched by include pattern (['"])(.*)\1 in '([^']*)'/;
const referencedViaPattern = /^ Referenced via (['"])(.*)\1 from file '([^']*)'/;
const libReferencesPattern = /^ Library referenced via (['"])(.*)\1 from file '([^']*)'/;
const typeLibraryPattern = /^ Type library referenced via (['"])(.*)\1 from file '([^']*)'/;
const fileRedirectsPattern = /^ File redirects to file '([^']*)'/
const compilerOptionsPattern = /^ Library '(.*)' specified in compilerOptions/;
const filesPattern = /^ Part of 'files' list in/;
const implicitTypeLibraryPattern = /^ Entry point for implicit type library/;
There seems to be no difference in the output between an import and an import type so my dependency graph can't cull the type imports that won't be emitted to the next stage in the build pipeline.
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Rechercherichtung
Beginne mit dem --explainFiles-Einstiegspunkt und verfolge, wie importierte Dateien in seiner Ausgabe dargestellt werden; das Issue gibt keine Quelldatei oder keinen Testpfad an. Als erledigt gilt die Ausgabe, wenn sie import type von einem Laufzeit-import unterscheidet, sodass Verbraucher reine Typabhängigkeiten aus ihrem Graphen ausschließen können.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- typescript
- Bereich
- compilers
- Issue-Typ
- Feature
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Aktivitätsstatus
- Veraltet
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 35/100