microsoft / microsoft/TypeScript

When using the MSBuild package with Blazor library extra content files are added to nupkg

Abierto
#42,907 7 comentarios 0 reacciones 3 asignados Ver en GitHub

@HannahOshlag ya está trabajando en esto.

Desde el 2/9/2022.

Visual Studio
Lenguaje dominante
Go
Estrellas
111k
Forks
14.3k
Merge medio
2 d 4 h
PR fusionados (30 d)
132

Descripción

Bug Report

When using the Microsoft.Typescript.MSBuild 4.2.1-rc to pack a Blazor Library project for nuget package, the compiled javascript files are added to the content and contentFiles folders of the nuget package, not just to staticWebAssets that Blazor build picks up.

GetTypeScriptOutputForPublishing MSBuild target seems to be the source of errors, if the content of that target is commented out, the nuget package does not have the above problem.

UPDATE

The real sideeffects of this coming to the surface when the build nuget package is consumed in another Blazor project and being built in VS 2019 16.x. As the JS files are showing up in the consuming project as project items and they should not. The worse thing is that if you put a tsconfig.json into the Logging package no matter if it is a <None.... item, that will also be packed and will cause compilation failure in the consuming project as there will be no source files to compile (that's how we started to notice this problem).

Repro
  1. Clone https://github.com/BlazorExtensions/Logging
  2. dotnet pack
  3. Observe the contents of the nupkg file
🔎 Search Terms

msbuild, nuget, blazor

🙁 Actual behavior

See in summary above.

🙂 Expected behavior

Nuget package should not have those extra files.

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.