microsoft / microsoft/TypeScript
Allow JSX intrinsics to have generic call signatures
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- Go
- Estrellas
- 111k
- Forks
- 14.3k
- Merge medio
- 2 d 4 h
- PR fusionados (30 d)
- 132
Descripción
Search Terms
type checking, jsx intrinsics, generic type, signature
Suggestion
Allow JSX intrinsics defined in IntrinsicElements to support generic call signatures, as is supported for user-defined SFCs.
Use Cases
Suppose you want to create a small DSL using JSX. You would need to model the primitive statements of the DSL. Your options are intrinsics and user-level components.
Intrinsics are clearly the more natural fit for this use case. Some reasons are:
- they are immediately available without separate import statements,
- the use of lower case makes them visually distinct from user-defined components,
However, intrinsics are not as capable as user-level components (pre-defined or user-defined). Currently they cannot be assigned generic type signatures. This makes them less expressive, and so, less useful.
The proposed change will bring parity between intrinsics and user-level components. In short, it will be possible to create a pre-defined set of intrinsics that are just as expressive as user-level SFCs.
Examples
Consider the following hypothetical DSL in JSX:
<for items={books} with={book => book.genre === 'scifi'}>
{book => (
<b>{book.title}</b>
)}
</for>
Currently, the for intrinsic cannot be generic over the type of the items, unlike user-defined SFCs which may be generic. To bring this capability to intrinsics, we would need to allow JSX.IntrinsicElements to support generic signatures. Here is what it might look like for this example DSL:
declare namespace JSX {
interface IntrinsicElements {
for: <T>(props: {
items: T[],
with?: (item: T) => boolean,
children?: (item: T) => Element | Element[]
}) => Element;
b: { children: string }
}
}
The implementation of this change will require a small number of changes to src/compiler/checker.ts. A good starting point is the function resolveJsxOpeningLikeElement.
Checklist
My suggestion meets these guidelines:
- This wouldn't be a breaking change in existing TypeScript/JavaScript code
- This wouldn't change the runtime behavior of existing JavaScript code
- This could be implemented without emitting different JS based on the types of the expressions
- This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
- This feature would agree with the rest of TypeScript's Design Goals.
Request to work on this feature
I would like to work on this feature improvement.
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Empieza en src/compiler/checker.ts, en resolveJsxOpeningLikeElement, y compara cómo se resuelven los intrinsics de JSX y los SFCs definidos por el usuario. Usa el ejemplo de IntrinsicElements del issue como comportamiento objetivo. Se considera terminado cuando se aceptan firmas de llamada genéricas en los intrinsics y sus parámetros de tipo fluyen a través de props y children.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- typescript
- Área
- compilers
- Tipo de issue
- Nueva funcionalidad
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Estancado
- Claridad
- Bien especificado
- Aptitud para principiantes
- 35/100