microsoft / microsoft/TypeScript

Support forwarding generic type in extending class

Abierto
#41,719 0 comentarios 12 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Awaiting More Feedback Suggestion
Lenguaje dominante
Go
Estrellas
111k
Forks
14.3k
Merge medio
1 d 19 h
PR fusionados (30 d)
117

Descripción

Search Terms

generic forward extends default

Suggestion

Have a shortcut syntax to make the generic of an extending class the same type as its Parent generic.

Current

class Parent <T extends any = any> {}
class Child <S extends any = any> extends Parent <S> {}

Suggestion

class Parent <T extends any = any> {}
class Child <infer S> extends Parent <S> {}

Use Cases

A default generic is useful to typescript users b

interface Proto = {}
class SomeClass <T extends Proto = Proto> {}

It can be extended like this:

class ExtendedClass extends SomeClass {}

but with this the author of ExtendedClass robs futher extenders of the possibility to extend the T generic of SomeClass. To allow further extension the author would need to add following construct.

class ExtendedClass <T extends Proto = Proto> extends SomeClass<T> {}

This is quite bothersome to the author of ExtendedClass. It requires the import of Proto and is easy to forget.
To make it a little bit easier I thought it might be a good idea to have this special syntax.

Examples

type Events = {
   open: () => {}
   close: () => {}
}

class System <TEvents extends Events = Events> {
   on <TEvent extends keyof TEvents> (event: TEvent, listener: TEvents[TEvent]): this { return this }
   off <TEvent extends keyof TEvents> (event: TEvent, listener: TEvents[TEvent]): this { return this }
}

class CorpSystem <infer TEvents> extends System <TEvents> {}

type SectionEvents = {
   stall: () => {}
} & Events

class SectionSystem <TEvents extends SectionEvents = SectionEvents> extends CorpSystem<TEvents> {}

const s = new SectionSystem()
s.on('stall', () => {})

As probably clear in the example, this thought came up when dealing with Node's EventEmitter but I think it can be useful to pretty much any use of extending classes with generics.

Checklist

My suggestion meets these guidelines:

  • This wouldn't be a breaking change in existing TypeScript/JavaScript code
  • This wouldn't change the runtime behavior of existing JavaScript code
  • This could be implemented without emitting different JS based on the types of the expressions
  • This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
  • This feature would agree with the rest of TypeScript's Design Goals.

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Comienza con la sintaxis infer propuesta y los ejemplos Parent, Child, System, CorpSystem y SectionSystem del issue. Determina cómo debe interactuar el forwarding genérico con la herencia de clases y los valores predeterminados; se considera terminado cuando la sintaxis y su comportamiento en la comprobación de tipos estén especificados y cubiertos por las pruebas de compilador adecuadas.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
typescript
Área
compilers
Tipo de issue
Nueva funcionalidad
Dificultad
5/5
Tiempo estimado
Más de una semana
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
25/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.