microsoft / microsoft/TypeScript

Support forwarding generic type in extending class

Open
#41,719 0 comments 12 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Awaiting More Feedback Suggestion
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

Search Terms

generic forward extends default

Suggestion

Have a shortcut syntax to make the generic of an extending class the same type as its Parent generic.

Current

class Parent <T extends any = any> {}
class Child <S extends any = any> extends Parent <S> {}

Suggestion

class Parent <T extends any = any> {}
class Child <infer S> extends Parent <S> {}

Use Cases

A default generic is useful to typescript users b

interface Proto = {}
class SomeClass <T extends Proto = Proto> {}

It can be extended like this:

class ExtendedClass extends SomeClass {}

but with this the author of ExtendedClass robs futher extenders of the possibility to extend the T generic of SomeClass. To allow further extension the author would need to add following construct.

class ExtendedClass <T extends Proto = Proto> extends SomeClass<T> {}

This is quite bothersome to the author of ExtendedClass. It requires the import of Proto and is easy to forget.
To make it a little bit easier I thought it might be a good idea to have this special syntax.

Examples

type Events = {
   open: () => {}
   close: () => {}
}

class System <TEvents extends Events = Events> {
   on <TEvent extends keyof TEvents> (event: TEvent, listener: TEvents[TEvent]): this { return this }
   off <TEvent extends keyof TEvents> (event: TEvent, listener: TEvents[TEvent]): this { return this }
}

class CorpSystem <infer TEvents> extends System <TEvents> {}

type SectionEvents = {
   stall: () => {}
} & Events

class SectionSystem <TEvents extends SectionEvents = SectionEvents> extends CorpSystem<TEvents> {}

const s = new SectionSystem()
s.on('stall', () => {})

As probably clear in the example, this thought came up when dealing with Node's EventEmitter but I think it can be useful to pretty much any use of extending classes with generics.

Checklist

My suggestion meets these guidelines:

  • This wouldn't be a breaking change in existing TypeScript/JavaScript code
  • This wouldn't change the runtime behavior of existing JavaScript code
  • This could be implemented without emitting different JS based on the types of the expressions
  • This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
  • This feature would agree with the rest of TypeScript's Design Goals.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the proposed infer syntax and the Parent, Child, System, CorpSystem, and SectionSystem examples in the issue. Determine how generic forwarding should interact with class inheritance and defaults; done means the syntax and its type-checking behavior are specified and covered by appropriate compiler tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
compilers
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.