microsoft / microsoft/TypeScript

"Isolated" annotation for functions that only act on inputs (distinct from 'pure')

Ouverte
#39,949 9 commentaires 7 réactions 0 personnes assignées Voir sur GitHub

Personne n'a encore pris cette issue.

Awaiting More Feedback Suggestion
Langage dominant
Go
Étoiles
111k
Forks
14.3k
Merge moyen
2 j 4 h
PR mergées (30 j)
132

Description

Search Terms

pure
isolated
functional
testing
functions

Suggestion

I'd like to be able to assert that a function is isolated, which I define as "acts only on arguments passed in as inputs". Isolated functions can be extracted more easily during refactors and can be tested in isolation from the rest of the codebase, opening the door to things like doctests.

A function that applies inherited scope to arguments cannot be isolated. If you're using jquery for instance, you'd want to pass $ in as an argument to your isolated functions even if it's available in the global scope.

NOTE: Claiming that a function is isolated is not the same thing as claiming that it's pure. At first glimpse they seem like synonyms, but I don't see how a pure function is possible in javascript given that you can't control the side-effects of invoking methods on arguments, etc. Passing $ in and then acting on it is by definition NOT a pure function, but we can still treat it as isolated! :)

The desired behavior is that if a function is annotated as isolated there'll be a compiler error thrown if it tries to access a value that's not one of its arguments.

Use Cases

Big Win: Easier Refactoring

An isolated function can be relocated into any source file without worrying about breaking its behavior by changing the scope it's situated in. It carries its own scope with it no matter where it lives. This opens the door too for interesting and novel approaches to the way code inhabits a filesystem. I'm imagining something like the Eve editor, where "files" are abstractions that may not be as helpful moving forward as they were in the past.

Bigger Win: Testing

If a function doesn't rely on external scope then testing it becomes trivial - every part of the function's behavior can be explored by tweaking input arguments. This not only makes the functions easier to test in the immediate case (simpler mocking, isolation etc) but also opens the door for things like doctests in the future. (see Elixir's doctests for an example of what I mean)

Examples

Think of isolation as a less strict purity. Because this is javascript we can't control what happens when we e.g. call a method on an argument to our function. The runtime behavior is unpredictable enough that purity can't be guaranteed without adding significant runtime-breaking constraints.

What we can do, though, is check to see if our function is only acting on inputs.

/*
* @isolated 
*/
function sum(x, y) { return x + y } // this works

/*
* @isolated
*/
function addX(value) { return value + x } // this throws a compiler error
this

Anything explicitly on this counts as an argument input, since you can always call/apply/bind to invoke it and pass a this value in. This would complicate refactoring if you're using prototypes, since you'd have to grab all references to the function not just the definition, but it still feels viable and useful to me?

This allows us to have the seeming contradiction of isolated methods on objects and instances, I think. There's probably some complexity here I'm not thinking about?

/*
* @isolated 
*/
function updateModel(delta) {
  this.model.patch(delta)
}

// and elsewhere

updateThisModel = updateModel.bind(model)
Existing code

Because this is an opt-in assertion there are no changes to existing codebases. Further, because the goal is to throw a compiler error when isolation is violated there's a happy path for incremental adoption within a codebase. A lot of core behavior should already be fairly isolated, and being able to make that assertion would bring a lot of new stability to the codebase.

/*
* @isolated
*/
function myReducer(accumulator, value) { return accumulator.push(value * 2) }
Purity (and its conspicuous absence)

Let's look at the following isolated function, which just does some JQuery shenanigans. We can assert that this function is isolated because $, selector and value are all passed in as arguments. But this code isn't pure because invoking jQuery like this has side effects.

We still get the benefit of isolation, though, because now we know we can test this function and all we have to do is mock $.

/*
* @isolated
*/
function setValue($, selector, value) { $(selector).value(value) }

Checklist

My suggestion meets these guidelines:

  • This wouldn't be a breaking change in existing TypeScript/JavaScript code
  • This wouldn't change the runtime behavior of existing JavaScript code
  • This could be implemented without emitting different JS based on the types of the expressions
  • This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
  • This feature would agree with the rest of TypeScript's Design Goals.

Guide de contribution

Ouvrir le guide de contribution

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Piste de recherche

L’issue ne nomme aucun fichier d’implémentation, point d’entrée ou test. Commencez par examiner la distinction proposée entre les fonctions isolées et pures, notamment la portée, les arguments, this et les effets de bord ; définissez les diagnostics du compilateur et le comportement nécessaires pour les exemples avant d’identifier les tests du compilateur concernés.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
javascript, typescript
Domaine
compilers
Type d'issue
Fonctionnalité
Difficulté
5/5
Temps estimé
Plus d'une semaine
Activité
À l'abandon
Clarté
À clarifier
Accessibilité débutants
25/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.