microsoft / microsoft/TypeScript

Reducible circular reference error (regression)

Open
#39,798 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Awaiting More Feedback Suggestion
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

TypeScript Version: 3.7.x-dev.20200728

Search Terms:

Code

export {}

type ShadowHostElementTagName =
  | 'span';
type ShadowHostElementTagNameMap_ = {
  [P in Extract<ShadowHostElementTagName, keyof HTMLElementTagNameMap>]: HTMLElementTagNameMap[P];
};

declare global {
  interface ShadowHostElementTagNameMap extends ShadowHostElementTagNameMap_ {
  }
  interface HTMLElementTagNameMap extends ShadowHostElementTagNameMap {
  }
}

Expected behavior:
pass
Actual behavior:
Type alias 'ShadowHostElementTagNameMap_' circularly references itself.(2456)
Playground Link: https://www.typescriptlang.org/play/index.html?ts=4.0.0-dev.20200728&ssl=1&ssc=1&pln=14&pc=2#code/KYDwDg9gTgLgBAbwL4CgUwJ5mHAygCwEMATCAdwAkIBnGAUQBtgBbYAOxgBVCBzAOUKs4AXhRw4AHzgByamEJtpAbnRYcBEuSq1GLdl14DWAWUJgA+iMRi4AbQAKcAJZs4dEDCiEAxjAA8GqSUNPRMrBzc-ILAADRwANbAGBAAZnAUnMYAMrrhBlEmZgB8ALoAXOmZOWH6kUbApmAOJSpIKijEwN4MhFA4PAwQAEaEDNbiLjDAUCk+6kRB2qF6EYbRjXCgU2zE1HgLWiG5tWuFFuNwqBMc07PeOBnZx6sFDWabHuy7+5rBOjUveobBA2VBIIA
Related Issues:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the provided TypeScript snippet in the linked Playground and confirm the TS2456 diagnostic versus the expected pass. Trace the compiler's circular type-alias checking for the mapped types and global HTMLElementTagNameMap declarations; done means the example passes without regressing circular-reference errors elsewhere.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.