microsoft / microsoft/TypeScript

If autoimporting import that is commented out - uncomment it instead of adding new one

Open
#39,690 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Awaiting More Feedback Suggestion
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

Search Terms

autoimport commented uncomment import

Suggestion

Consider we have such imports already in some file:

import React, {
  useState,
  // useEffect,
} from 'react';

Then - if you write useEffect - TS will suggest auto importing it - which is cool. If you choose to auto import it - your import statement will look something like:

import React, {
  useState,
  // useEffect,
  useEffect,
} from 'react';

Which is not a big deal, but leads to some kind of duplication.

Desired result would be:

import React, {
  useState,
  useEffect,
} from 'react';

Which is just removing the comment next to the import I want to use.

Checklist

My suggestion meets these guidelines:

  • This wouldn't be a breaking change in existing TypeScript/JavaScript code
  • This wouldn't change the runtime behavior of existing JavaScript code
  • This could be implemented without emitting different JS based on the types of the expressions
  • This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
  • This feature would agree with the rest of TypeScript's Design Goals.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in TypeScript's language-service auto-import handling and find the tests covering imports with commented-out named imports. Add a regression case for the shown React-style import and verify that selecting the auto-import removes the comment rather than adding a duplicate import.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.