microsoft / microsoft/TypeScript
Allow to overwrite generic templates
还没有人认领这个 Issue。
- 主要语言
- Go
- 星标
- 111k
- 派生
- 14.4k
- 平均合并
- 1 天 19 小时
- 30 天内合并 PR
- 117
描述
Search Terms
- overwrite generic this type
- overwrite template argument
- class overwrite generic
- overwrite type generic
Suggestion
Allow to overwrite generic type templates.
Use Cases
I'm currently developing a modular ORM and query builder, where especially in the query builder part it would be necessary to overwrite a generic template argument.
Examples
Here's a super simple example of a query builder. The select method should return a new instance of Query but with a different subset of T (since it limits the fields being selected).
interface Entity {}
class Query<T extends Entity> {
findOne(): T;
select(names: (keyof T)[]): this<Partial<T>>; //doesn't work
}
interface User {
username: string;
group: string;
created: Date;
}
const item: User = new Query<User>().findOne();
const item: Partial<User> = new Query<User>().select(['username']).findOne();
This is just to demonstrate the use case. You could of course further describe the type of select by using Pick etc, but I wanted to keep it simple. Please note that I could return Query<Partial<T>> instead, but that would break class inheritance.
To my awareness this use case can't be covered with the newest TypeScript version.
Another use case I had:
interface Query<T> {
findOne(): T;
}
interface AdapterInterface {
createQuery<T extends Entity>(classType: Constructor<T>): Query<T>;
}
class Database<A extends AdapterInterface> {
constructor (private adapter: A) {}
// here is the magic with the return type, which doesn't work, but is necessary since
// `T` of A['createQuery'] needs to be inferred from query<T>.
query<T extends Entity>(classType: Constructor<T>): ReturnType<A['createQuery']><T> {
return this.adapter.createQuery(classType);
}
}
class MyAdapterQuery<T> extends Query<T> {
additionalMethod(): this;
}
class MyAdapter {
createQuery<T extends Entity>(classType: Constructor<T>): MyAdapterQuery<T> {
return new MyAdapterQuery<T>();
}
}
const database = new Database(new MyAdapter);
database.query(User).additionalMethod();
Checklist
My suggestion meets these guidelines:
- This wouldn't be a breaking change in existing TypeScript/JavaScript code
- This wouldn't change the runtime behavior of existing JavaScript code
- This could be implemented without emitting different JS based on the types of the expressions
- This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
- This feature would agree with the rest of TypeScript's Design Goals.
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
从 issue 中的 generic-template 示例开始,审查 TypeScript 当前如何建模泛型类和方法返回类型。在确定实现和测试位置之前,确定预期的类型检查语义并评估所需的编译器设计;当所提出的用例无需更改生成的 JavaScript 即可通过类型检查时,即视为完成。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- typescript
- 领域
- compilers
- Issue 类型
- 功能
- 难度
- 5/5
- 预计耗时
- 一周以上
- 活跃度
- 停滞
- 描述清晰度
- 需要澄清
- 新手友好度
- 25/100