microsoft / microsoft/TypeScript
Support Implicit Generics Inference
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
Search Terms
implicit generics, broader type inference, better type inference
Suggestion
I'd like TypeScript to know when two types are unknown, but equal.
That is, say I've function equals():
type T = { type: 'a', p1: boolean } | { type: 'b', p2: string };
function equals(a: T, b: T) {
// Currently, we have to write:
if (a.type === 'a' && b.type === 'a') { return a.p1 === b.p1; }
if (a.type === 'b' && b.type === 'b') { return a.p2 === b.p2; }
return false;
// But I'd like to be able to write:
if (a.type !== b.type) { return false; }
return a.type === 'a' ? a.p1 === b.p1 : a.p2 === b.p2;
}
Use Cases
I can't think about other use cases except comparisons (if you know let me know), but I think they're common enough. This will also make them somewhat faster (no need to check both's type).
Checklist
My suggestion meets these guidelines:
- This wouldn't be a breaking change in existing TypeScript/JavaScript code
- This wouldn't change the runtime behavior of existing JavaScript code
- This could be implemented without emitting different JS based on the types of the expressions
- This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
- This feature would agree with the rest of TypeScript's Design Goals.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No repository files, tests, or entry points are named. Start by reproducing the equals example in TypeScript and determine the expected narrowing behavior when discriminants are equal. Done means the requested implicit inference works without breaking existing type-checking behavior, with tests covering the example.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- compilers
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100