microsoft / microsoft/TypeScript
Allow trailing lines in multiline comment directives
@DanielRosenwasser ci sta già lavorando.
Dal 8/5/2020.
- Lingua principale
- Go
- Stelle
- 111k
- Fork
- 14.3k
- Merge medio
- 1g 19h
- PR unite (30g)
- 117
Descrizione
TypeScript Version: 4.0.0-dev.20200507
Search Terms: multiline comment directive ts-expect-error ts-ignore
Code
const x = 0;
/* @ts-ignore
continuing comment
that could be multiline*/
x();
Expected behavior:
The comment looks like a directive to ignore the x();'s type checking complaint.
Actual behavior:
Comment directive parsing only looks at the last line of the comment. It should also allow the first line of the comment.
I'm in favor of not allowing any other lines (i.e. "middle" lines) to count as directives. Extending to allow characters after the @ts- has precedent from what's already allowed (we're really just adding newlines). But putting characters before the @ts- has a precedent of not working even in single-line comments.
/* Here we use a
@ts-ignore
that is multiline*/
Related Issues: Following discussion in https://github.com/microsoft/TypeScript/pull/38228#discussion_r420940329, as suggested by @sheetalkamat.
Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Valutazione
Questa issue non è ancora stata valutata.