microsoft / microsoft/TypeScript
Declaration emit should not inline type definitions
@weswigham 已经在做这个了。
开始于 2020年3月4日。
- 主要语言
- Go
- 星标
- 111k
- 派生
- 14.4k
- 平均合并
- 1 天 19 小时
- 30 天内合并 PR
- 117
描述
TypeScript Version: 3.8.3, 3.8.1, probably others
Search Terms:
declaration inlining, dts inlining, declaration inline, inline literal, declaration literal
Code
// parent.ts
import { num, obj } from "./child"
export const reExportNum = num;
export const reExportObj = obj;
// child.d.ts
export declare const num: number;
export declare const obj: { a: 1 };
tsc index.ts --declaration
Expected behavior:
Declaration emit for parent.ts should not inline types.
// parent.d.ts
import { num, obj } from "./child"
export declare const reExportNum: typeof num;
export declare const reExportObj: typeof obj;
Actual behavior:
Today, declaration emit for parent.ts inlines the types and eliminates the import of the child.d.ts type definition.
// parent.d.ts
export declare const reExportNum: number;
export declare const reExportObj: {
a: 1;
};
This is a correctness issue, because consumers of parent.d.ts will not get the correct types if the types in child.d.ts change.
In practice, this is most likely to happen when parent and child are in separate packages, because they are published independently, i.e. an application uses parent-package which uses types from child-package. This is exacerbated by the current practice on npm of parent-package depending on an unpinned version, using package.json dependency syntax "child-package": "*".
This issue was co-authored with @robpalme
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
评估
这个 Issue 还没有评估数据。