microsoft / microsoft/TypeScript

strictPropertyInitialization option doesn't work with computed properties

Open
#36,302 2 comments 5 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Awaiting More Feedback Suggestion
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

TypeScript Version: 3.7.x-dev.20200118

Search Terms:

Code

const sym = Symbol();
class A {
    a: 0;
    ['b']: 0;
    [sym]: 0;
    [Symbol.toPrimitive]: 0;
}

Expected behavior:
Error with all properties.
Actual behavior:
Error only with 'a'.
Playground Link: https://www.typescriptlang.org/play/index.html?ts=3.8.0-dev.20200118&ssl=1&ssc=1&pln=7&pc=2#code/MYewdgzgLgBBCeBbGBeGBlJAjEAbAFAJQDcAUMLgIYQQwCCMA3qTKzJQFwwAMZbMAbQDkWIQF0uvFmwEJEEnnxmZEOXADooIAAoAnAJaJ9UfQDcApgqkBfIA

Related Issues:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the strictPropertyInitialization check using the supplied class example and Playground link. Trace how named and computed properties are handled, then add coverage for the reported expected behavior and verify that diagnostics include all properties.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.