microsoft / microsoft/TypeScript
Suggestion: optional globals
Personne n'a encore pris cette issue.
- Langage dominant
- Go
- Étoiles
- 111k
- Forks
- 14.4k
- Merge moyen
- 1 j 19 h
- PR mergées (30 j)
- 117
Description
Search Terms
Suggestion
Extracted from this related issue: https://github.com/microsoft/TypeScript/issues/21965
Currently TypeScript has no way to represent a global which may or may not exist at runtime.
For example, given a global called foo, we can only define it as:
declare global {
const foo: number;
}
But what if foo does not always exist?
We can't define it as T | undefined because this does not reflect the runtime behaviour. T | undefined means "this will be declared but its value might be undefined", but the global may not be declared at all, in which case any references would result in ReferenceErrors at runtime.
declare global {
const foo: number | undefined;
}
// TypeScript is happy for us to reference this. There's no compile error.
// The type is `number | undefined`.
// At runtime, if the global doesn't exist, we'll get a `ReferenceError` 😒
foo;
If there was a way to mark a global as optional, TypeScript would require a proper guard (typeof foo !== 'undefined') before it can be safely accessed. This way, TypeScript is alerting us to the possibilty of a runtime exception.
declare global {
// example syntax
const foo?: number;
}
// Compile error 😇
// Runtime exception 😇
foo;
if (typeof foo !== 'undefined') {
// No compile error 😇
// No runtime exception 😇
// Type is `number`
foo;
}
Use Cases
Examples of "optional globals" below.
In code that is shared between a client (browser) and server (Node):
windowwill only exist during the client runtimetypeof window !== undefined ? window.alert('yay') : undefined;globalandrequirewill only exist during the server runtimetypeof process !== undefined ? process.env.FOO : undefined;
In code which may or may not be under test using Cypress, the global Cypress will only exist during runtime when the code is under test.
const getEnvVar = key => typeof Cypress !== 'undefined' ? Cypress.env(key) : process.env[key];
Examples
See above.
Checklist
My suggestion meets these guidelines:
- This wouldn't be a breaking change in existing TypeScript/JavaScript code
- This wouldn't change the runtime behavior of existing JavaScript code
- This could be implemented without emitting different JS based on the types of the expressions
- This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
- This feature would agree with the rest of TypeScript's Design Goals.
Guide de contribution
Ouvrir le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Piste de recherche
Commencez par lire l’issue associée #21965 et les exemples de optional-global dans cette issue ; aucun fichier source ni point d’entrée de test n’est indiqué. La réalisation nécessiterait de convenir d’une conception dans laquelle les variables globales éventuellement non déclarées doivent être protégées par un garde typeof, tout en préservant le comportement existant à l’exécution, ainsi que des tests correspondants du compilateur.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- javascript, typescript
- Domaine
- compilers
- Type d'issue
- Fonctionnalité
- Difficulté
- 5/5
- Temps estimé
- Plus d'une semaine
- Activité
- À l'abandon
- Clarté
- Plutôt claire
- Accessibilité débutants
- 25/100