__decorate helper should not use `this` when targeting modules

TypeScript Version: 3.7.x-dev.201xxxxx

Search Terms: __decorate this module

Code

class Foo {
  @property() x = 1;
}

Expected behavior:
Top-level this reference is not emitted.

Actual behavior:

The __decrate variable is declared like:

var __decorate = (this && this.__decorate) || function (decorators, target, key, desc) {

Since top-level this is always undefined in modules, (this && this.__decorate) || can be omitted. It's only a few bytes, but the presence of top-level this also causes warnings in other downstream tools like Rollup.

A few other things could be fixed for an ES6+ helper, btw:

• Use const instead of var (allows for some VM optimizations)
• Remove Reflect.decorate
• Don't use arguments

Playground Link: https://www.typescriptlang.org/play/?ts=Nightly#code/MYGwhgzhAEBiD29oG8BQ1oAEAOAne2AprgC4CeAFAJTQAe0AvNAIwDcqAvkA

Related Issues: None?

Reproduisez l’exemple du TypeScript Playground lié en utilisant la version 3.7.x-dev indiquée ou le compilateur actuel, et inspectez le helper __decorate émis. Suivez le point d’entrée du compilateur qui émet ce helper ; le travail est terminé lorsque la sortie du module ne contient plus la référence this au niveau supérieur, tandis que le comportement des décorateurs reste intact.