microsoft / microsoft/TypeScript

"paths" option should allow untyped entries

Offen
#35,772 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Dieses Issue hat noch niemand übernommen.

Awaiting More Feedback Suggestion
Vorherrschende Sprache
Go
Sterne
111k
Forks
14.4k
Ø Merge
1 T. 19 Std.
Gemergte PRs (30 T.)
117

Beschreibung

Search Terms

paths option untyped declare module

Suggestion

The existing "paths" option allows you to control the types used for bare specifiers in your source code, by mapping them as keys to a list of candidate target specifiers.

// tsconfig.json
{
  "paths": {
    // <bare-specifier>: [ <candidate1>, <candidate2> ]
    "foo": [ "external-foo", "fallback-foo" ]
        // if "external-foo" is not found, "fallback-foo" will be attempted, otherwise error
  }
}

I suggest we allow the final element in the array of candidates to be the empty string "". If hit, it would mean "This module exists but is untyped."

Use Cases

Our build system uses "paths" to implement a searching loader for typed dependencies. We know all the acceptable source specifiers ahead-of-time, and so create one property for each - this ensures precise auto-completions for external dependencies in VS Code. We do not know if the target specifiers will exist on disk or not, e.g. the user may not yet have populated the disk via "npm install".

Strict: Some users want to be strict and see errors if no match was found. This behavior comes for free from "paths" today.

Sloppy: Sometimes users want to be sloppy and have the source specifier be typed as any if no match was found. This behavior is not possible today because there is no way to express "this modules exists but is untyped" in "paths" today.

Workaround

We have not discovered any alternative that allows sloppy behavior to be implemented.

The closest workaround is to write declare module "foo" in an ambient declaration file. However this does not work because it clobbers (takes precedence over) the same entry in "paths". Our desire is for untyped behavior to be the last resort, not the first choice.

Examples

Current behaviour: This works today and is fine for implementing strict behavior.

// tsconfig.json
{
  "paths": {
    "foo": [ "external-foo", "fallback-foo" ]
        // assume "external-foo" and "fallback-foo" do not exist on disk
  }
}

// index.ts
import aDefaultImport, { aNamedImport } from "foo";  // Error(2307): Cannot find module

Proposed behaviour: Here's how we could achieve sloppy behavior.

// tsconfig.json
{
  "paths": {
    "foo": [ "external-foo", "fallback-foo", "" ]
        // assume "external-foo" and "fallback-foo" do not exist on disk
  }
}

// index.ts
import aDefaultImport, { aNamedImport } from "foo";  // no error

The usage of "foo" would result in no compile-time error.

Checklist

My suggestion meets these guidelines:

  • This wouldn't be a breaking change in existing TypeScript/JavaScript code
  • This wouldn't change the runtime behavior of existing JavaScript code
  • This could be implemented without emitting different JS based on the types of the expressions
  • This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
  • This feature would agree with the rest of TypeScript's Design Goals.

Beitragsleitfaden

Beitragsleitfaden öffnen

Erste Schritte

  1. Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
  3. Forke das Repository und arbeite in einem Branch.
  4. Öffne einen Pull Request, der die Issue-Nummer nennt.

Rechercherichtung

Es werden keine Dateien, Tests oder Einstiegspunkte genannt. Beginne damit, die Behandlung von tsconfig.json-Pfaden und der Modulauflösung durch den Compiler zu lokalisieren, und verfolge anschließend, wie ein abschließender leerer Kandidat ein untypisiertes Modul darstellen könnte. Erledigt ist es, wenn die vorgeschlagene Konfiguration Importe ohne Fehler kompiliert, sobald frühere Pfadkandidaten nicht vorhanden sind.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
typescript
Bereich
compilers
Issue-Typ
Feature
Schwierigkeit
5/5
Geschätzter Aufwand
Über eine Woche
Aktivitätsstatus
Veraltet
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
35/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.