microsoft / microsoft/TypeScript
Disallowing `throw`ing expressions that aren't assignable to `Error`
未关闭
还没有人认领这个 Issue。
Awaiting More Feedback
Suggestion
- 主要语言
- Go
- 星标
- 111k
- 派生
- 14.4k
- 平均合并
- 1 天 19 小时
- 30 天内合并 PR
- 117
描述
Search Terms
throw, throwing non-error
Suggestion
Add typechecking to throw statement, allowing it to only throw Errors and anys.
Code currently allowed, but with strong potential for bugs:
throw null;
throw undefined;
throw 'foobar';
throw '';
throw 42;
throw {foo: 'bar'};
throw potentiallyNullable; // with –strictNullChecks
After implementing this feature request, such code wouldn't be allowed.
Use Cases
Even if it's possible to throw non-errors in JavaScript code, it's extremely confusing and hard to debug. Failing to properly handle such cases happened even to Mozilla.
Examples
Forbidden code:
throw null;
throw undefined;
throw 'foobar';
throw 42;
throw {foo: 'bar'};
throw potentiallyNullable; // with –strictNullChecks
Allowed:
throw new Error();
throw null as any;
Checklist
My suggestion meets these guidelines:
- This wouldn't be a breaking change in existing TypeScript/JavaScript code - it can break existing TypeScript code.
- This wouldn't change the runtime behavior of existing JavaScript code
- This could be implemented without emitting different JS based on the types of the expressions
- This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
- This feature would agree with the rest of TypeScript's Design Goals.
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
该 issue 未提供文件路径或测试路径。首先在 TypeScript 编译器及其测试中定位 throw 语句的类型检查,然后检查 nullable 表达式和 any 表达式的处理方式。当列出的非 Error 表达式被拒绝,而 Error 表达式和 any 表达式仍被允许,且不改变生成的 JavaScript 时,即视为完成。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- typescript
- 领域
- compilers
- Issue 类型
- 功能
- 难度
- 5/5
- 预计耗时
- 一周以上
- 活跃度
- 停滞
- 描述清晰度
- 基本清楚
- 新手友好度
- 35/100