microsoft / microsoft/TypeScript

"Go To Type Definition" for type names should navigate to the type definition

Abierto
#33,147 1 comentario 2 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Domain: LS: Symbol Navigation In Discussion Suggestion
Lenguaje dominante
Go
Estrellas
111k
Forks
14.3k
Merge medio
2 d 4 h
PR fusionados (30 d)
132

Descripción

"Go To Type Definition" doesn't doesn't work when the selection is itself a type. Instead, you get a "No type definition found" error. I can understand why it was implemented in this way ("types don't have a type!") but IMHO this behavior unnecessarily inconsistent and confusing for users. If I ask for the type definition of a type, then I should be taken to the... type definition! ;-)

I'm filing this at @weswigham's request to split it out of #6209. IMHO, if #6209 is implemented as I'm suggesting (where Go To Definition would navigate to the actual implementing source, not the DefinitelyTyped .d.ts) then fixing this issue would be helpful because it'd make both operations more consistent:

  • Go To Definition would always navigate to implementation code (not to type declarations), regardless of what symbol is selected.
  • Go to Type Definition would always navigate to type declarations, regardless of what symbol is selected

Search Terms

Go to Type Definition
No type definition found for
getTypeDefinitionsAtPosition - this is one possible method to change in a PR

Suggestion

Go to Type Definition should, when called for a type, return the location of the type definition.

Use Cases

Discussed above

Examples

type X = {a: number};
const a: X = {a: 1};

In VSCode, select and right-click on the second X and choose Go To Type Definition.

Expected: navigates to declaration
Actual: No type definition for 'X'

Checklist

My suggestion meets these guidelines:

  • This wouldn't be a breaking change in existing TypeScript/JavaScript code
  • This wouldn't change the runtime behavior of existing JavaScript code
  • This could be implemented without emitting different JS based on the types of the expressions
  • This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
  • This feature would agree with the rest of TypeScript's Design Goals.

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Start with the getTypeDefinitionsAtPosition entry point named in the issue and reproduce the example by selecting the type name in the TypeScript language service. Done means Go To Type Definition returns the type declaration for a selected type instead of reporting that no type definition was found.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
typescript
Área
compilers, developer-experience
Tipo de issue
Nueva funcionalidad
Dificultad
3/5
Tiempo estimado
1-2 días
Estado de actividad
Estancado
Claridad
Bien especificado
Aptitud para principiantes
48/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.