microsoft / microsoft/TypeScript
[Proposal] Conceptual(virtual) module in .d.ts
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- Go
- Estrellas
- 111k
- Forks
- 14.3k
- Merge medio
- 1 d 19 h
- PR fusionados (30 d)
- 117
Descripción
Motivation
A common requirement during JavaScript application development is to bundle multiple modules together. There are many bundling tools to do this, such as rollup.js, webpack.
The usual case is that library maintainers organize their source in a internal structure. When publish, bundling tool is called to roll all modules up into one. Users of the library can only see the bundled module. They don't know and don't care about the original structure.
Everything works fine except when library maintainer wish to provide type declaration file(s) for the library so users can benefit from Typescript. Because Typescript compiler can only generate declaration files according to the original source structure. Even the compiler option outFile is used, it just produce a single declaration file which contains multiple "ambient" modules. For the declaration file's consumer, they can still see and refer to the original module.
For example. Say there is a library has the following source structure:
index.ts
export { Apple } from "./apple";
export { Pen } from "./pen";
apple.ts
export class Apple {}
pen.ts
export class Pen {}
Bundling tool bundle the index.ts to generated a single module "applepen.js".
Typescript compiler generate the declaration file like this:
declare module "apple" { export class Apple {} }
declare module "pen" { export class Pen {} }
declare module "index" {
export { Apple } from "./apple";
export { Pen } from "./pen";
}
It would be better to replace module name "index" to the library's real name. It can be done if the triple slash directive is inserted into index.ts:
/// <amd-module name="applepen"/>
export { Apple } from "./apple";
export { Pen } from "./pen";
It will infer the tsc to generate the declaration file like:
declare module "apple" { export class Apple {} }
declare module "pen" { export class Pen {} }
declare module "applepen" {
export { Apple } from "./apple";
export { Pen } from "./pen";
}
Now you can use the declaration file as:
import { Apple, Pen } from "applepen";
Yes, that's really what we expect. The declaration of "applepen" exactly match what bundling tool does.
Is that OK? No. Users are able, according the typing information the declaration file expresses, refer to a module called "apple". So:
import { Apple } from "apple";
is valid and cause no compiling error. But it's wrong because there is no "apple" module exists.
Even if we can carefully write any import statement, we are losing the convenience to use Typescript language server's auto-completion. That's mean when you type:
const apple = new Appl
The IDE will infer you Apple from a non-existing module "apple";
A kind of tools may helper, such as dts-bundle-generator or gift(the author is me :) ). But they are hack and problematical.
This proposal is aims to overcome the above issue.
Solution
Concept
A conceptual module is a kind of ambient module that cannot be used outside the non-conceptual module enclosing it.
Conceptual modules are only used to express structure. No any actual JS codes are generated for them.
To declare a conceptual module, you should use the module-declaration syntax, with the following restricts:
- Conceptual modules are only valid in declaration file(*.d.ts file);
- There shall be one non-conceptual ambient module enclosing it(ie.
declare module "xx" {}); - The name element in module-declaration AST shall obey the rule of standard module specifier(ie. shall be a string-literal);
Example
declare module "applepen" {
module "apple" {
export class Apple {}
}
module "pen" {
export class Pen {}
}
export { Apple } from "apple";
export { Pen } from "pen";
}
const apple: import("apple").Appe; // Error: cannot resolve module "apple"
In above example, there are two conceptual module "apple" and "pen" in non-conceptual module "applepen". All portion in module "applepen" can import the two conceptual module. Outside the "applepen" module can not, however:
A use case:
another file:
import { Apple } from "applepen"; // OK
import { Pen } from "pen"; // Error: cannot resolve module "pen"
Implementation
The syntax of "A module declaration is enclosed in other one" is supported already. The only things need to be done are:
- Add codes to
resolveExternalModule()inChecker.tsto support resolve conceptual modules; - Code-completion stuffs.
More information
The second restrict described above requires the enclosing non-conceptual module to be "ambient". It actually a restrict from current Typescript.
In current, a module in .d.ts like
xx.d.ts
module "ambient-module-with-no-declare-modifier" {
}
is an error. The Typescript requires it have a declare keyword modifier. But it is indeed recognized as a module which just has the declare modifier in type checker.
If it is REALLY treated as an error. The second restrict can be modified as:
- There shall be one module-declaration or source file enclosing it;
So we can define our bundle as not a "ambient" module, instead, as an "external" module:
applepen.d.ts
module "apple" {
export class Apple {}
}
module "pen" {
export class Pen {}
}
export { Apple } from "apple";
export { Pen } from "pen";
Checklist
My suggestion meets these guidelines:
- This wouldn't be a breaking change in existing TypeScript/JavaScript code
- This wouldn't change the runtime behavior of existing JavaScript code
- This could be implemented without emitting different JS based on the types of the expressions
- This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
- This feature would agree with the rest of TypeScript's Design Goals.
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Comienza leyendo el manejo existente de las declaraciones de módulos anidados y resolveExternalModule() en Checker.ts; después, revisa el trabajo de completado de código mencionado en la propuesta. El resultado previsto es que los módulos conceptuales de los archivos .d.ts se resuelvan dentro de su módulo ambient contenedor, pero no puedan importarse desde fuera de él, y que el completado refleje ese ámbito.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- typescript
- Área
- compilers
- Tipo de issue
- Nueva funcionalidad
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 25/100