microsoft / microsoft/TypeScript
Fourslash server tests silently ignore compiler option directives
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
The existing working solution is to create a tsconfig.json fourslash-file, which is probably a better way to do things given that the server tests are supposed to mimic reality more closely, so my proposal would be to throw early when double-slash-attersand compiler directives are encountered.
Semi-related: #25081
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue does not name a file or test; begin by locating the server fourslash test entry point and how a tsconfig.json fourslash-file is loaded. Reproduce a test containing a double-slash-at-sign compiler directive, then verify that the harness rejects it early while the tsconfig.json path remains supported.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- compilers, testing-qa
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100