microsoft / microsoft/TypeScript
Immutable-By-Default Flags
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
Search Terms
readonly, default, immutable
Suggestion
Adding flags under the strict umbrella to default to immutability in different cases, and a new mutable keyword.
Use Cases
I'm creating this issue as a parent issue to track a couple of issues that already exist for specific cases:
- Class methods: https://github.com/microsoft/TypeScript/issues/22315, https://github.com/microsoft/TypeScript/issues/22315#issuecomment-400708470 in particular
- Arrays: https://github.com/microsoft/TypeScript/issues/32467
- Interfaces: No issue yet, left a comment in https://github.com/microsoft/TypeScript/issues/32467#issuecomment-519333922
- https://github.com/microsoft/TypeScript/issues/21152
Off of the top of my head, these flags would have some direct advantages:
- They clearly state the intention of the whole project in regards to mutability
- It's very common for new members of teams to forget to add the
readonlykeyword or useT[]rather thanReadonlyArray<T>accidentally. Defaulting to immutability would help prevent these accidents, and amutablekeyword would be easy to find bytslintor even a simplegrep, to automatically request review in PRs or leave an automated commentthis PR introduces mutation.
Examples
Examples should probably live in the children GitHub issues, but I'm copying here my comment for a quick example:
interface T {
n: number // immutable
mutable s: string // mutable
}
const o: T = {
n: 42,
s: 'hello world',
}
o.n = 43 // error
o.s = '👋🌎' // ok
Checklist
My suggestion meets these guidelines:
- This wouldn't be a breaking change in existing TypeScript/JavaScript code
- This wouldn't change the runtime behavior of existing JavaScript code
- This could be implemented without emitting different JS based on the types of the expressions
- This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
- This feature would agree with the rest of TypeScript's Design Goals.
Backwards Compatibility
@AnyhowStep made an interesting comment on this issue.
Basically this feature wouldn't be any problem for applications, but it could be problematic for libraries, as the emitted .d.ts may be imported from a library/application that isn't using this flag or is using an older TS version.
Possible solutions:
- A pre-processor directive (https://github.com/microsoft/TypeScript/issues/32758#issuecomment-569369439)
- Always emitting
d.tswithreadonly, nevermutable(possibly behind another flag?) - downlevel-dts
Records and Tuples
The Record and Tuple proposal has reached stage 2, so it may be arriving to TS soon-ish. It seems closely related to this issue, but I don't think it fully addresses it.
readonly interface
The possibility of using the readonly keyword for an entire interface has been suggested in A cheaper, easier to implement middle ground could be https://github.com/microsoft/TypeScript/issues/21152.
readonly interface State {
prop1: string;
prop2: string;
...
prop22: string;
}
This would probably be a much cheaper and less disruptive feature to implement, and could be a great starting point.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked child issues for class methods, arrays, interfaces, and readonly interfaces, then review the parent issue's compatibility concerns. No implementation files or tests are named; the work is complete only after the scope, syntax, and declaration-file behavior are agreed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- compilers
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 15/100