microsoft / microsoft/TypeScript
Backticks around module names in module declarations
Dieses Issue hat noch niemand übernommen.
- Vorherrschende Sprache
- Go
- Sterne
- 111k
- Forks
- 14.3k
- Ø Merge
- 1 T. 19 Std.
- Gemergte PRs (30 T.)
- 117
Beschreibung
Search Terms
- backticks
- module declaration
- NoSubstitutionTemplateLiteral
- template string
Other related issues/PRs:
- https://github.com/microsoft/TypeScript/issues/30962 and the fix, https://github.com/microsoft/TypeScript/pull/31042
- https://github.com/microsoft/TypeScript/issues/29318,
- https://github.com/microsoft/TypeScript/issues/29331
- https://github.com/microsoft/TypeScript/issues/31548, which generalizes some things about template literals, but explicitly doesn't address module declarations because of the way they're handled internally
Suggestion
It'd be nice for backticks to be allowed in module declarations. For example:
declare module `semver` {}
This causes an error with typescript 3.5.1: Cannot invoke an expression whose type lacks a call signature. Type 'NodeModule' has no compatible call signatures.ts(2349)
Use Cases
I'd like to be able to use backticks more consistently in my code.
Similar to https://github.com/microsoft/TypeScript/issues/30962:
This is especially important because the backticks mode of the quotes rule from ESLint breaks programs (cf yarnpkg/berry#70 for an example). While it could be seen as an ESLint bug, I think it should be possible for TS to use raw template string interchangeably with regular strings as long as they don't contain variables.
Examples
This would be allowed
declare module `semver` {}
and would be equivalent to
declare module 'semver' {}
Checklist
My suggestion meets these guidelines:
- This wouldn't be a breaking change in existing TypeScript/JavaScript code
- This wouldn't change the runtime behavior of existing JavaScript code
- This could be implemented without emitting different JS based on the types of the expressions
- This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
- This feature would agree with the rest of TypeScript's Design Goals.
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Rechercherichtung
Beginne damit, das zugehörige Issue #30962 und die Behebung in PR #31042 zu lesen, und verfolge dann, wie Moduldeklarationen behandelt werden, da Issue #31548 darauf hinweist, dass sie intern unterschiedlich behandelt werden. Die Arbeit ist abgeschlossen, wenn ein no-substitution template literal in einer Moduldeklaration akzeptiert wird und sich wie der entsprechende Name in Anführungszeichen verhält, mit Abdeckung der Beispiele in diesem Issue.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- typescript
- Bereich
- compilers
- Issue-Typ
- Feature
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Aktivitätsstatus
- Veraltet
- Klarheit
- Klar beschrieben
- Anfängerfreundlichkeit
- 45/100