microsoft / microsoft/TypeScript
Move types from jsdoc quickfix (instead of copy)
Dieses Issue hat noch niemand übernommen.
- Vorherrschende Sprache
- Go
- Sterne
- 111k
- Forks
- 14.3k
- Ø Merge
- 1 T. 19 Std.
- Gemergte PRs (30 T.)
- 117
Beschreibung
Search Terms
jsdoc quickfix- 80004
Suggestion
There's a great quickfix available to copy JSDoc type annotations to TypeScript annotations:

When you do this, however, you still have type annotations in your JSDoc. This is duplicative and is likely to lead to the types getting out of sync over time. It's best to avoid putting type information in JSDoc once you're using TypeScript.
I'd like a quickfix that annotates types and removes the types from the JSDoc.
Use Cases
This would be helpful for any project converting from JavaScript to TypeScript. You should convert your JSDoc types to TypeScript types and you should remove types from your JSDoc once you do. This sort of quickfix would help people get to the right place.
Examples
/**
* @param a {string} Base string.
* @param b {string=} Optional string to add
* @return {string}
*/
function foo(a, b) {
if (b) return a + b;
return a;
}
should get converted to:
/**
* @param a Base string.
* @param b Optional string to add
*/
function foo(a: string, b?: string): string {
if (b) return a + b;
return a;
}
rather than:
/**
* @param a {string} Base string.
* @param b {string=} Optional string to add
* @return {string}
*/
function foo(a: string, b: string | undefined): string {
if (b) return a + b;
return a;
}
Checklist
My suggestion meets these guidelines:
- This wouldn't be a breaking change in existing TypeScript/JavaScript code
- This wouldn't change the runtime behavior of existing JavaScript code
- This could be implemented without emitting different JS based on the types of the expressions
- This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
- This feature would agree with the rest of TypeScript's Design Goals.
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Rechercherichtung
Beginne damit, den vorhandenen JSDoc quickfix zu suchen, der dem Suchbegriff 80004 zugeordnet ist, und verfolge, wie er JSDoc-Typen in TypeScript-Annotationen umwandelt. Verwende das Beispiel als Abnahmekriterium: Verschiebe die Typen in die Funktionssignatur und entferne dabei die Typinformationen aus dem JSDoc, einschließlich der Rückgabeannotation.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- javascript, typescript
- Bereich
- developer-experience, tooling
- Issue-Typ
- Feature
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Aktivitätsstatus
- Veraltet
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 45/100