microsoft / microsoft/TypeScript

Make `DOMStringList` generic

Open
#30,983 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Awaiting More Feedback Suggestion
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

Search Terms

DOMStringList, DOMStringMap, DOMString

Suggestion

I'd be nice if DOMStringList had an optional generic so that a more restricted string type could be used for the list item type. The generic could default to string so that existing code using the type does not break.

The implementation would be along the lines of:

interface DOMStringList<T extends string = string> {
    readonly length: number;
    contains(string: T): boolean;
    item(index: number): T | null;
    [index: number]: T;
}

Use Cases

Libraries that wrap native DOM methods may return the DOMStringLists but want more strict types.

Examples

const dbOpenRequest = indexedDB.open("store", 1);

dbOpenRequest.onupgradeneeded = () => {
  const db = dbOpenRequest.result;
  db.createObjectStore('fruits');
  db.createObjectStore('meats');
}

dbOpenRequest.onsuccess = () => {
  const db = dbOpenRequest.result;
  const storeNames = db.objectStoreNames as DOMStringList<'fruits' | 'meats'>;
};

Checklist

My suggestion meets these guidelines:

  • This wouldn't be a breaking change in existing TypeScript/JavaScript code
  • This wouldn't change the runtime behavior of existing JavaScript code
  • This could be implemented without emitting different JS based on the types of the expressions
  • This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
  • This feature would agree with the rest of TypeScript's Design Goals.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the DOMStringList declaration and review how its length, contains, item, and indexed access members are typed. Implement the optional string-constrained generic with a string default, then verify that both the existing form and the restricted DOMStringList<'fruits' | 'meats'> usage remain valid.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
compilers
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.