microsoft / microsoft/TypeScript

Pull required references from referenced projects.

Ouverte
#30,608 6 commentaires 1 réaction 0 personnes assignées Voir sur GitHub

Personne n'a encore pris cette issue.

Awaiting More Feedback Suggestion
Langage dominant
Go
Étoiles
111k
Forks
14.3k
Merge moyen
2 j 4 h
PR mergées (30 j)
132

Description

Search Terms

Inherit references from referenced project.
Pull required references from referenced projects.

Suggestion

I have projects that have references to other projects, but one other project has references to another project it is dependent on. That seems to be completely ignored, and is causing compiler errors. It forces me to have to know all the references of the referenced projects and pull those also, which I should not have to do.

Use Cases

This is pretty obvious. In a typical C# project in Visual Studio (for example), referencing a project resolves other references from that referenced project, and so on. It is not good practice to force projects to pull direct dependencies that are referenced indirectly by 3rd parties.

Examples

tsconfig.json

{
  "references": [
    { "path": "3rdPartyProject" } // 3rdPartyProjectFile.d.ts
  ],

3rdPartyProject/tsconfig.json

{
  "references": [
    { "path": "Another3rdPartyProject" } // Another3rdPartyProjectFile.d.ts
  ],

This setup only outputs 3rdPartyProjectFile.d.ts, as required by the first referenced projects. Intellisense fails, however, because the references in 3rdPartyProject/tsconfig.json are not included, thus Another3rdPartyProjectFile.d.ts is missing. This forces me to open all related tsconfig references and pollute my project json with them. This also may not scale well.

Checklist

My suggestion meets these guidelines:

  • This wouldn't be a breaking change in existing TypeScript/JavaScript code
  • This wouldn't change the runtime behavior of existing JavaScript code
  • This could be implemented without emitting different JS based on the types of the expressions
  • This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
  • This feature would agree with the rest of TypeScript's Design Goals.

Guide de contribution

Ouvrir le guide de contribution

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Piste de recherche

Commencez par les entrées des projets référencés dans tsconfig.json et 3rdPartyProject/tsconfig.json, en vous concentrant sur la manière dont IntelliSense résout les fichiers .d.ts générés. Déterminez pourquoi Another3rdPartyProjectFile.d.ts n’est pas inclus via la référence transitive. C’est terminé lorsque les références indirectes aux projets sont disponibles sans les dupliquer dans la configuration du projet racine.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
typescript
Domaine
compilers
Type d'issue
Fonctionnalité
Difficulté
5/5
Temps estimé
Plus d'une semaine
Activité
À l'abandon
Clarté
Plutôt claire
Accessibilité débutants
30/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.