microsoft / microsoft/TypeScript

Symbol definition improvement

Open
#30,561 0 comments 14 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

In Discussion Suggestion
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

Search Terms

symbol in:title, symbol improvement, symbol description definition

Suggestion

By using more and more symbol in my projects, and to make debugging easier in development mode, I fill the optional description to Symbol. Then, on production, I remove all description during the bundling process:
image

So I was thinking that it could be really useful to have the same approach for TypeScript - playground:
image
image

Just imagine we don't have xsymbol<"test"> but the "native" symbol<"test"> or symbol("test") to be closer to DevTools.

Then, by extending this approach, I don't know if it could be helpful to increase the typing inference.
Given this code:

const foo = {
    type: 'foo' as 'foo',
    foo: ''
};

const bar = {
    type: 'bar' as 'bar',
    bar: ''
};

type FooBarAction = typeof foo | typeof bar;

function getType<T>(input: {type: T}): T {
    return input.type;
}

function foobar(action: FooBarAction) {
    switch (action.type) {
        case getType(foo):
            action.foo;
            break;
        case getType(bar):
            action.bar;
            break;
    }
}

image

Here, according to the type property value, the action provide correctly foo property or bar property.

But, if I replace them by symbol:

const sFoo = {
    type: Symbol('sfoo'),
    sfoo: ''
};

const sBar = {
    type: Symbol('sbar'),
    sbar: ''
};

type SFooBarAction = typeof sFoo | typeof sBar;

function sfoobar(action: SFooBarAction) {
    switch (action.type) {
        case getType(sFoo):
            action.sfoo;
            break;
        case getType(sBar):
            action.sbar;
            break;
    }
}

image
image

Here TypeScript cannot resolve properly the correct definition of my action variable and keep saying that it get the SFooBarAction type, so only type property is available.

According to this PR #30196, I understand that working on symbol in the core system of TypeScript is not an easy thing, but probably it could be helpful if the optional description of Symbol as a definition descriptor to have the unique symbol in the definition. But definitely, as soon as we provide same description, we will face the same problem as today.

Full Playground

Use Cases

For the first part, everywhere when we use Symbol.

For the second part, as soon as unique value is required, like for Event Emitter, Action in Redux architecture, ...

Examples

See above on the Suggestion section

Checklist

My suggestion meets these guidelines:

  • This wouldn't be a breaking change in existing TypeScript/JavaScript code
  • This wouldn't change the runtime behavior of existing JavaScript code
  • This could be implemented without emitting different JS based on the types of the expressions
  • This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
  • This feature would agree with the rest of TypeScript's Design Goals.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the linked TypeScript Playground examples, comparing the string-discriminant cases with the Symbol cases and reviewing the related PR #30196. The work would need a settled design for Symbol descriptions, unique values, and control-flow narrowing, with corresponding compiler behavior and tests demonstrating the requested inference.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, typescript
Domain
compilers
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.