microsoft / microsoft/TypeScript

PluginModule.onConfigurationChanged not called when plugin config in tsconfig.json changes

Abierto
#28,969 3 comentarios 0 reacciones 1 asignado Ver en GitHub

@sheetalkamat ya está trabajando en esto.

Desde el 11/12/2018.

Domain: LS: TSServer Experience Enhancement Suggestion
Lenguaje dominante
Go
Estrellas
111k
Forks
14.4k
Merge medio
1 d 19 h
PR fusionados (30 d)
117

Descripción

TypeScript Version: 3.3.0-dev.20181208

Search Terms:

plugin configuration change
onConfigurationChanged

Expected behavior:

PluginModule.onConfigurationChanged is called when the configuration of the plugin in tsconfig.json changes. The Project already watches the tsconfig.json and therefore knows when the config of a plugin changes.

Actual behavior:

PluginModule.onConfigurationChanged is only called when the client sends a ConfigurePlugin command.

Related Issues:
#15915 is basically the same issue from 1,5 years ago. Back then it was decided this is working as intended and a plugin is responsible for watching the config file.
In the meantime onConfigurationChanged was introduced in #28106. Since ConfigurePlugin command is supposed to override any config in tsconfig.json, a plugin that watches for config file changes would need special handling to account for that fact.

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.