microsoft / microsoft/TypeScript
cloneNode should return sub type, not Node
Open
Nobody has claimed this yet.
Bug
Domain: lib.d.ts
Help Wanted
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
When I do `someElement.cloneNode()`, I want the returned element to be the same type as `someElement`, but right now it's returning type `Node`.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the DOM type declaration for cloneNode and the existing TypeScript type-checking tests. Check how the return type is currently declared, then add coverage showing that cloning a specific element preserves its subtype; done means the type checker accepts the subtype-specific result.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, typescript
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 64/100