microsoft / microsoft/TypeScript

language service suggestion for Declare property '...' in constructor argument

Open
#28,022 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Domain: LS: Quick Fixes Experience Enhancement Suggestion
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

Search Terms

  • typescript declare property in constructor
  • typescript language service declare property in constructor

Suggestion

When a non-existing property x is accessed on this in a class method, one of the fixes that ts language service currently suggests, is:

Declare property x

Which adds property x to the class.
It would be nice to also have Declare property x in constructor arguments.
It can use private access modifier by default.

Use Cases

While it's generally useful, it becomes especially handy when developing applications with DI frameworks like Angular that use constructor injection to wire dependencies together.

Examples

-

Checklist

My suggestion meets these guidelines:

  • This wouldn't be a breaking change in existing TypeScript / JavaScript code
  • This wouldn't change the runtime behavior of existing JavaScript code
  • This could be implemented without emitting different JS based on the types of the expressions
  • This isn't a runtime feature (e.g. new expression-level syntax)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the existing TypeScript language-service suggestion for “Declare property x” and trace its code-fix entry point and tests, if present. Add the requested alternative for declaring x in constructor arguments with private as the default modifier, then verify the suggestion in the described class-method case and its generated result.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
devtools
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.