microsoft / microsoft/TypeScript
This-function parameters must be specified in caller *and* callee, even for methods
Personne n'a encore pris cette issue.
- Langage dominant
- Go
- Étoiles
- 111k
- Forks
- 14.4k
- Merge moyen
- 1 j 19 h
- PR mergées (30 j)
- 117
Description
This means that only very careful people will benefit from assignability checking (and therefore argument checking at call sites). (Due to contextual typing, code that uses a this-typed library will get improved body checking a lot of the time.)
Specifically, assignability checking only happens when this is explicitly declared by both sides.
Instead, class methods should implicitly have this: this unless declared otherwise.
Given the declarations:
declare let f: (this: string, x: number) => void;
declare class C {
m(x: number): void;
n(this: this, x: number): void;
}
declare let c: C;
Expected behavior:
c.m = f // error, 'this: string' is not assignable to 'this: string'
f = c.m // error, 'this: C' is not assignable to 'this: string'
f = c.n // error, 'this: string' is not assignable to 'this: C'
c.n = f // error, 'this: C' is not assignable to 'this: string'
Actual behavior:
c.m = f // no error
f = c.m // no error
f = c.n // error, 'this: string' is not assignable to 'this: C'
c.n = f // error, 'this: C' is not assignable to 'this: string'
Comments
The "this parameter" feature was designed this way to balance four concerns:
- Backward compatibility with un-annotated code.
- Compiler efficiency.
- Consistency between class and interface
this. - Quality of error checking.
As you can see, (4) took the biggest hit by requiring annotation on both the source and target of the assignment.
Backward compatibility
The problem with unannotated code is that we can't tell whether a function is intended to be called with or without this.
Functions
--noImplicitThis helps address this problem by forcing annotation of this parameters for functions.
TODO: Work through some examples.
Methods
Actually, for methods, we do have a pretty good idea that a method is not supposed to be removed from its class. Even if the class implements an interface, we the class methods should still be able to refer to class-private implementation details.
TODO: Work through some examples.
Interface consistency
The problem is that interfaces are frequently used to interact with objects instead of the class type itself. But interfaces are used in lots of other contexts as well. That means we can't infer intent with an interface, but if we don't add this: this to interface methods, we're left with a bad assignment problem:
interface I {
m(x: number): void;
}
class C implements I {
y = 12;
m(x: number) {
return this.y + x;
}
}
let c = new C();
f = c.m;
f(); // error, this must of type 'C'
let i: I = c;
f = i.m;
f(); // ok, this is not annotated
"Assignment escape hatches" like this exist throughout TypeScript, but adding more is not a good thing.
Efficiency
Briefly, if every interface has a this type, then every interface will be generic, even in non-OO code. This causes the compiler to generate about double the number of types internally, which is slower and uses more memory than today.
Guide de contribution
Ouvrir le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Piste de recherche
Commencez par les exemples d’assignabilité dans l’issue et suivez la manière dont les paramètres this explicites sont vérifiés pour les méthodes, les classes et les interfaces. Une modification complète produirait les quatre erreurs attendues tout en tenant compte de la rétrocompatibilité, de la cohérence des interfaces, de l’efficacité du compilateur et des exemples non résolus marqués TODO.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- typescript
- Domaine
- compilers
- Type d'issue
- Fonctionnalité
- Difficulté
- 5/5
- Temps estimé
- Plus d'une semaine
- Activité
- À l'abandon
- Clarté
- Plutôt claire
- Accessibilité débutants
- 25/100