microsoft / microsoft/TypeScript-TmLanguage
TypeScript - incorrect highlighting when a new line is added
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 471
- Forks
- 149
- PR merge metrics
- No merged PRs in 30d
Description
Does this issue occur when all extensions are disabled?: Yes
- VS Code Version: 1.63.2
- OS Version: Windows_NT x64 6.3.9600
Steps to Reproduce:
- Paste the code below to the VS Code
type testType = {
on<Key extends string>
(eventName: `${Key}Changed`): void;
}
let a = 1;
The result is, that the "let" keyword is highlighted incorrectly. Same happens with any other keyword (const, function, etc.):
After removing the new line between the second and the third line, everything works correctly. The content of the third line doesn't matter; there could be only parentheses as well.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the report in VS Code 1.63.2 or an equivalent environment using the provided TypeScript snippet, first confirming the highlighting change caused by the blank line. Then trace the TypeScript TextMate grammar files in this repository to find the rule handling the generic type and following declaration. Done means keywords such as let, const, and function highlight correctly with and without the blank line.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100