microsoft / microsoft/TypeScript-TmLanguage

Wrong scope "support.variable.property.dom"

Open
#879 3 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Suggestion You can do this
Dominant language
TypeScript
Stars
471
Forks
149
PR merge metrics
No merged PRs in 30d

Description

Properties of my own object fall under the scope of "support.variable.property.dom":

screenshot_wrong_scope_1

This covers a significant number of commonly used words:

screenshot_wrong_scope_2

This clearly looks like a bug.
I cannot fix this in my color scheme for example by changing the "foreground" to my normal property color because if I define "name" property as a functional expression it still falls under "support.variable.property.dom" and does not change to "entity.name.function" as it happens with normal properties and as a result is not colored in my function color:

screenshot_wrong_scope_3

screenshot_wrong_scope_4

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the reported highlighting with the scopes support.variable.property.dom and entity.name.function, using the screenshots and examples in the issue as the reference. Trace the TypeScript grammar rules that assign scopes to object properties and verify that ordinary properties and function-valued properties receive the intended scopes when the behavior is corrected.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.