microsoft / microsoft/TypeScript-TmLanguage
Colors doesn't work when using a comment inside a map:
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 471
- Forks
- 149
- PR merge metrics
- No merged PRs in 30d
Description
TS and JS Grammar Extension version:
Version: 1.54.0-insider (user setup)
Commit: 192c817fd350bcbf3caecae22a45ec39bae78516
Date: 2021-02-19T05:14:28.632Z
Electron: 11.2.3
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: 8.7.220.31-electron.0
OS: Windows_NT x64 10.0.19042
Code
class A {
private readonly _workspaceLayoutInfos = new Map<string, ISetTerminalLayoutInfoArgs>();
private readonly _workspaceLayoutInfos2 = new Map</* workspace id */string, ISetTerminalLayoutInfoArgs>();
}
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start from the TypeScript TextMate grammar files described by the repository and reproduce the coloring behavior with the supplied TypeScript Map example. Compare the two declarations, especially the inline comment inside the generic type, and verify that the corrected grammar colors both forms consistently in the supported editor extension.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, typescript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100