microsoft / microsoft/TypeScript-TmLanguage

Multiple spelling errors in scopes

Open
#1,034 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
471
Forks
149
PR merge metrics
No merged PRs in 30d

Description

Both the scopes meta.paramter.array-binding-pattern.js and meta.objectliteral.js seem to have a spelling error.

Code

/* Spelling issue 1 */
function func([ a, b ]) { } // [ a, b ] scope is meta.paramter (missing an e)
function func({ a, b }) { } // { a, b } scope is meta.parameter

/* Spelling issue 2 */
const obj = { "key": 0 } // { key: 0 } scope is meta.objectliteral, while scope for "key" is meta.object-literal.key

Screenshots

Issue 1
image

Issue 2
image
image

Notes

There are a few more missing dashes in words that shouldn't be compound, however they aren't as important as there is no consistency issue with those.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect the TextMate grammar definitions that produce the reported scopes meta.paramter.array-binding-pattern.js and meta.objectliteral.js, then compare them with the corresponding parameter and object-literal scopes shown in the examples. Correct the inconsistent spellings and verify the resulting scopes against both code samples.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
devtools
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.