microsoft / microsoft/MixedReality-GraphicsTools-Unity

Update the Graphics Tools/Standard AssignNewShaderToMaterial method to auto-migrate URP Lit shaders

Open
#36 0 comments 0 reactions 1 assignee View on GitHub

@palmerdesigns is already working on this.

Since Nov 7, 2023.

enhancement good first issue
Dominant language
C#
Stars
209
Forks
49
PR merge metrics
No merged PRs in 30d

Description

Describe the problem

Right now the Graphics Tools/Standard and Graphics Tools/Standard Canvas shader GUIs have logic to auto-migrate shader properties from the Unity/Standard shader and old HoloToolkit/Fast Configurable shader but not the URP/Lit shader.

Describe the solution you'd like

AssignNewShaderToMaterial should be updated to pull properties that can be migrated from URP/Lit.

Describe alternatives you've considered

Live without.

Additional context

None

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.