microsoft / microsoft/FeatureManagement-JavaScript
Missing await causes true evaluation
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 19
- Forks
- 6
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 4
Description
if (temp.isEnabled("foo")) {
button.className = "cool";
button.textContent = "Cool Button";
} else {
button.className = "lame";
button.textContent = "Lame Button";
}
We will always run the "cool" path here, because I didn't put an await on the isEnabled call. I think this is bad.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the isEnabled implementation and any related usage or tests, then reproduce the conditional shown in the issue. The issue provides no target behavior beyond identifying the missing-await problem, so the intended resolution and completion criteria need clarification before implementation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, typescript
- Domain
- api
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100