Adaptive Cards: Add cards to our tests suite

Open
#2,575 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
html
Domain
frontend, testing

Research direction

Start by inspecting the existing Adaptive Cards tests and the linked Cards.zip, using the listed CalendarReminder, Inputs, Restaurant, TrelloCardActionBar, TrelloCardCreated, and VSTSCard cases as the target coverage. Done means these cards, including the TrelloCardCreated Comment action, are included in the Web Chat test suite and their rendering issues can be caught.

Written by the indexing model from the issue text.

Description

backlog feature-request technical-debt

Feature Request

Today, we test Adaptive Cards in Web Chat. Our channel also test Adaptive Cards in a different test suite.

Recently, they discovered an issue in Adaptive Cards 1.1.2 that caused bad rendering of cards. The issue have been fixed in Adaptive Cards 1.2.0.

It will be great to include some of the bad cards in Web Chat test suite. So we can also catch and report those problems sooner.

The following are the name of the cards in our channel test suite:

  • CalendarReminder
  • Inputs
  • Restaurant
  • TrelloCardActionBar
  • TrelloCardCreated, click "Comment" button
  • VSTSCard

Those cards can be found in this ZIP file.

(Thanks @hristp for testing every card in the test suite and compared the differences carefully.)

[Enhancement]

Dominant language
HTML
Stars
1.8k
Forks
1.6k
Avg merge
22h 58m
Merged PRs (30d)
2

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microsoft/BotFramework-WebChat

All issues in microsoft/BotFramework-WebChat

Similar issues

More Web Dev issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.