microsoft / microsoft/BotFramework-WebChat
Missing dependency on p-defer-es5
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 1.8k
- Forks
- 1.6k
- Avg merge
- 22h 58m
- Merged PRs (30d)
- 2
Description
Is it an issue related to Adaptive Cards?
No
Is this an accessibility issue?
No
What version of Web Chat are you using?
Latest production
Which distribution are you using Web Chat from?
Bundle (webchat.js)
Which hosting environment does this issue primarily affect?
Web apps
Which browsers and platforms do the issue happened?
No response
Which area does this issue affect?
Development experience
Which theme pack does this issue affect?
I did not test it on other theme packs
What is the public URL for the website?
No response
Please describe the bug
Several pieces of code in this package import p-defer-es5 directly. However, this package is not listed in dependencies in package.json. This causes an issue with installers such as pnpm as they don't "flatten" the node_modules. Specifically, this is causing an issue in ODSP codebase. Please add p-defer-es5 as a dependency. Thanks!
Do you see any errors in console log?
No response
How to reproduce the issue?
- Use pnpm to install this package
- Try to run/webpack the code
What do you expect?
Webpack to succeed
What actually happened?
Webpack is unable to import p-defer-es5
Do you have any screenshots or recordings to repro the issue?
No response
Adaptive Card JSON
No response
Additional context
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with package.json and inspect the dependency declarations for the package imported by the code. Reproduce the failure using pnpm, then verify that webpack succeeds and can import p-defer-es5 after installation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, webpack
- Domain
- build-system, developer-experience
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 65/100