microsoft / microsoft/BotFramework-DirectLineJS
rxjs - peer dependency
Open
Nobody has claimed this yet.
Bot Services
customer-replied-to
customer-reported
- Dominant language
- TypeScript
- Stars
- 199
- Forks
- 133
- PR merge metrics
- No merged PRs in 30d
Description
rxjs should be specified as a peer dependency.
This will allow users to use rxjs6 with rxjs-compat.
Currently I get errors such as
Type 'import("c:/Code/AngularWebComponents/node_modules/botframework-directlinejs/node_modules/rxjs/Observable").Observable<import("c:/Code/AngularWebComponents/node_modules/botframework-directlinejs/built/directLine").Activity>' is not assignable to type 'import("c:/Code/AngularWebComponents/node_modules/rxjs/internal/Observable").Observable<import("c:/Code/AngularWebComponents/node_modules/botframework-directlinejs/built/directLine").Activity>'.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting the package dependency metadata for BotFramework-DirectLineJS and how its published package declares rxjs. Verify the dependency arrangement against the reported rxjs 6 and rxjs-compat installation, then confirm that the resulting package avoids duplicate rxjs instances and preserves the existing build or test checks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100