microsoft / microsoft/BotFramework-DirectLineJS

Attachments with incorrect base64 contentUrl in sendActivity fails silently

Ouverte
#159 8 commentaires 0 réactions 1 personne assignée Voir sur GitHub

@ckkashyap y travaille déjà.

Depuis le 6/2/2019.

Langage dominant
TypeScript
Étoiles
199
Forks
133
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

Versions

What package version of the SDK are you using: 4.0.8 (botbuilder, botbuilder-dialogs)
What nodejs version are you using: v.8.12.0
What browser version are you using: Chrome v69
What os are you using: Windows 10

Describe the bug

When trying to create an attachment that is intentionally corrupt (via an incorrect base64 url), the bot fails silently without throwing an error.

To Reproduce

  1. Create bot with command to trigger send activity with an attachment with the following code:
  try {
    console.log('Start');

    await context.sendActivity({
      type: 'message',
      attachments: [{
        contentType: 'text/plain',
        contentUrl: 'data:image/png;base64,abc\nabc',
        name: 'dot.png'
      }]
    });

    console.log('Succeeded');
  } catch (err) {
    console.log(err);
    throw err;
  }

And on the BotFrameworkAdapter instance, register an onTurnError handler like so:

adapter.onTurnError = async (context, error) => {
  console.log(error);
  await context.sendActivity(`Sorry, ran into an error!\n  ${ error.message }`);
}
  1. Run bot, send command utterance to send activity
  2. Sending the command failed
    Note that there is no error in the console, and the line console.log("Succeeded"); is never reached. Similarly, onTurnError is never triggered.

The message fails silently, and after timing out, the Web Chat instance logs a 502 Bad Gateway error.

Sending other messages pass through successfully.

Expected behavior

Since the contentUrl is invalid, the bot should try and catch an error when this command is initiated.

[bug]

Guide de contribution

Ouvrir le guide de contribution

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.